Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 2907123002: Add histograms for dircrypto migration data size stats (Closed)

Created:
3 years, 6 months ago by hashimoto
Modified:
3 years, 6 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add histograms for dircrypto migration data size stats Data is collected by Chrome OS side code https://chromium-review.googlesource.com/c/512482/ BUG=714935 Review-Url: https://codereview.chromium.org/2907123002 Cr-Commit-Position: refs/heads/master@{#476155} Committed: https://chromium.googlesource.com/chromium/src/+/ce954697f872bb3f9baafc7e49655e48a2121e0d

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +17 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (4 generated)
hashimoto
isherman@, could you review this change?
3 years, 6 months ago (2017-05-29 06:21:37 UTC) #2
Ilya Sherman
LGTM https://codereview.chromium.org/2907123002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2907123002/diff/1/tools/metrics/histograms/histograms.xml#newcode9742 tools/metrics/histograms/histograms.xml:9742: +<histogram name="Cryptohome.DircryptoMigrationTotalByteCountInMb" units="MB"> nit: If you hadn't already ...
3 years, 6 months ago (2017-05-30 19:46:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2907123002/1
3 years, 6 months ago (2017-06-01 00:40:18 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 02:27:55 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ce954697f872bb3f9baafc7e4965...

Powered by Google App Engine
This is Rietveld 408576698