Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2907113002: [MD History] Allow Home and End to scroll the history list. (Closed)

Created:
3 years, 6 months ago by calamity
Modified:
3 years, 6 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD History] Allow Home and End to scroll the history list. This CL makes the Home and End keys scroll the history list when a history item is focused. BUG=726646 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2907113002 Cr-Commit-Position: refs/heads/master@{#475311} Committed: https://chromium.googlesource.com/chromium/src/+/a97d1d58e65cb1143207f83d788a762dfa342a9b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/resources/md_history/history_item.js View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
calamity
3 years, 6 months ago (2017-05-29 04:17:53 UTC) #3
tsergeant
lgtm
3 years, 6 months ago (2017-05-29 06:52:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2907113002/1
3 years, 6 months ago (2017-05-29 07:07:12 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-05-29 08:24:37 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a97d1d58e65cb1143207f83d788a...

Powered by Google App Engine
This is Rietveld 408576698