MD Bookmarks: Vulcanize page to reduce load time

MD Bookmarks: Vulcanize page to reduce load time

This compiles the Bookmarks page in much the same way as the
History/Downloads/Settings pages. Testing locally, this appears to cut
about 25% off page load time (600ms to 450ms).

BUG=727177
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2907083002
Cr-Commit-Position: refs/heads/master@{#475399}
Committed: https://chromium.googlesource.com/chromium/src/+/9abc1e4d296152077d667de7864bc580eccb0638

[tsergeant, 2017-05-29 03:06:19]

Description was changed from

==========
MD Bookmarks: Vulcanize page to reduce load time

BUG=727177
==========

to

==========
MD Bookmarks: Vulcanize page to reduce load time

BUG=727177
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2017-05-29 03:15:37]

Description was changed from

==========
MD Bookmarks: Vulcanize page to reduce load time

BUG=727177
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Bookmarks: Vulcanize page to reduce load time

This compiles the Bookmarks page in much the same way as the
History/Downloads/Settings pages. Testing locally, this appears to cut
about 25% off page load time (600ms to 450ms).

BUG=727177
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2017-05-29 03:45:08]

Patchset #2 (id:20001) has been deleted

[tsergeant, 2017-05-29 03:45:31]

tsergeant@chromium.org changed reviewers:
+ calamity@chromium.org

[tsergeant, 2017-05-29 03:45:31]

Vulcanize is super easy now!

[tsergeant, 2017-05-29 03:45:45]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-29 03:46:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 05:13:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 05:13:07]

Dry run: This issue passed the CQ dry run.

[calamity, 2017-05-29 07:26:51]

lgtm

https://codereview.chromium.org/2907083002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/BUILD.gn (right):

https://codereview.chromium.org/2907083002/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/BUILD.gn:20: ":vulcanize",
optional nit: remove comma.

https://codereview.chromium.org/2907083002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/bookmarks.html (right):

https://codereview.chromium.org/2907083002/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/bookmarks.html:22: <link rel="import"
href="chrome://bookmarks/app.html">
Why does this have to move?

[tsergeant, 2017-05-30 00:35:52]

https://codereview.chromium.org/2907083002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/BUILD.gn (right):

https://codereview.chromium.org/2907083002/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/BUILD.gn:20: ":vulcanize",
On 2017/05/29 07:26:51, calamity wrote:
> optional nit: remove comma.

This comma is placed there by `git cl format`, for whatever reason

https://codereview.chromium.org/2907083002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/bookmarks.html (right):

https://codereview.chromium.org/2907083002/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/bookmarks.html:22: <link rel="import"
href="chrome://bookmarks/app.html">
On 2017/05/29 07:26:51, calamity wrote:
> Why does this have to move?

It doesn't make much difference now, but putting these at the bottom unblocks
rendering, which we can use to add the same super simple toolbar shim as
settings:

https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/settin...

[tsergeant, 2017-05-30 00:36:13]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2017-05-30 00:36:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 00:40:39]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496104573497200,
"parent_rev": "3719e2aac68d32c7670be43a16632c5cd32157e2", "commit_rev":
"9abc1e4d296152077d667de7864bc580eccb0638"}

[commit-bot: I haz the power, 2017-05-30 00:40:49]

Description was changed from

==========
MD Bookmarks: Vulcanize page to reduce load time

This compiles the Bookmarks page in much the same way as the
History/Downloads/Settings pages. Testing locally, this appears to cut
about 25% off page load time (600ms to 450ms).

BUG=727177
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Bookmarks: Vulcanize page to reduce load time

This compiles the Bookmarks page in much the same way as the
History/Downloads/Settings pages. Testing locally, this appears to cut
about 25% off page load time (600ms to 450ms).

BUG=727177
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2907083002
Cr-Commit-Position: refs/heads/master@{#475399}
Committed:
https://chromium.googlesource.com/chromium/src/+/9abc1e4d296152077d667de7864b...
==========

[commit-bot: I haz the power, 2017-05-30 00:40:50]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9abc1e4d296152077d667de7864b...