Make CounterDirectiveMap a class and implement a Clone() method.

Make CounterDirectiveMap a class and implement a Clone() method.

CounterDirectiveMap is currently a typedef of a HashMap, which means
it can't be extended with the Clone method that is required by
StyleRareNonInheritedData when it becomes generated. This patch
makes it into a class and adds a Clone method so that it can be
copied by a generated StyleRareNonInheritedData.

BUG=628043
Review-Url: https://codereview.chromium.org/2907063002
Cr-Commit-Position: refs/heads/master@{#475884}
Committed: https://chromium.googlesource.com/chromium/src/+/09c379de358b916213f0591a5214b60e76dfb224

[shend, 2017-05-28 22:50:41]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-28 22:50:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shend, 2017-05-28 22:55:24]

shend@chromium.org changed reviewers:
+ nainar@chromium.org

[shend, 2017-05-28 22:55:25]

Hi Naina, PTAL

[nainar, 2017-05-28 23:54:34]

lgtm

[commit-bot: I haz the power, 2017-05-29 01:03:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 01:03:32]

Dry run: This issue passed the CQ dry run.

[shend, 2017-05-30 04:30:04]

shend@chromium.org changed reviewers:
+ meade@chromium.org

[shend, 2017-05-30 04:30:05]

Hi Eddy, PTAL

[meade_UTC10, 2017-05-31 05:26:10]

lgtm with nit

https://codereview.chromium.org/2907063002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/CounterDirectives.h (left):

https://codereview.chromium.org/2907063002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/CounterDirectives.h:104:
std::unique_ptr<CounterDirectiveMap> Clone(const CounterDirectiveMap&);
Where's the implementation for this function? I can't see it being deleted in
this CL?

[shend, 2017-05-31 06:31:04]

https://codereview.chromium.org/2907063002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/CounterDirectives.h (left):

https://codereview.chromium.org/2907063002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/CounterDirectives.h:104:
std::unique_ptr<CounterDirectiveMap> Clone(const CounterDirectiveMap&);
On 2017/05/31 at 05:26:09, meade_UTC10 wrote:
> Where's the implementation for this function? I can't see it being deleted in
this CL?

Good catch. Removed the corresponding implementation.

[shend, 2017-05-31 06:31:44]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 06:31:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 10:40:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 10:41:00]

Dry run: This issue passed the CQ dry run.

[shend, 2017-05-31 12:09:57]

The CQ bit was checked by shend@chromium.org

[shend, 2017-05-31 12:09:58]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org,
nainar@chromium.org
Link to the patchset: https://codereview.chromium.org/2907063002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-31 12:10:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 12:13:26]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496232597630010,
"parent_rev": "7644280ec41728613b951df0e1c5b71d4eea73f5", "commit_rev":
"09c379de358b916213f0591a5214b60e76dfb224"}

[commit-bot: I haz the power, 2017-05-31 12:13:36]

Description was changed from

==========
Make CounterDirectiveMap a class and implement a Clone() method.

CounterDirectiveMap is currently a typedef of a HashMap, which means
it can't be extended with the Clone method that is required by
StyleRareNonInheritedData when it becomes generated. This patch
makes it into a class and adds a Clone method so that it can be
copied by a generated StyleRareNonInheritedData.

BUG=628043
==========

to

==========
Make CounterDirectiveMap a class and implement a Clone() method.

CounterDirectiveMap is currently a typedef of a HashMap, which means
it can't be extended with the Clone method that is required by
StyleRareNonInheritedData when it becomes generated. This patch
makes it into a class and adds a Clone method so that it can be
copied by a generated StyleRareNonInheritedData.

BUG=628043

Review-Url: https://codereview.chromium.org/2907063002
Cr-Commit-Position: refs/heads/master@{#475884}
Committed:
https://chromium.googlesource.com/chromium/src/+/09c379de358b916213f0591a5214...
==========

[commit-bot: I haz the power, 2017-05-31 12:13:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/09c379de358b916213f0591a5214...