Map new subtrees when they are attached to the node hierarchy visible to a connection.

Map new subtrees when they are attached to the node hierarchy visible to a connection.

R=sky@chromium.org
http://crbug.com/365012

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271493

[Ben Goodger (Google), 2014-05-16 23:15:47]

OK updated this to be more correct

[sky, 2014-05-16 23:28:22]

LGTM

https://codereview.chromium.org/290703002/diff/20001/mojo/services/public/cpp...
File mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc
(right):

https://codereview.chromium.org/290703002/diff/20001/mojo/services/public/cpp...
mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc:41:
base::Bind(&QuitRunLoopOnChangesAcked));
nit: indent 2 more.

https://codereview.chromium.org/290703002/diff/20001/mojo/services/view_manag...
File mojo/services/view_manager/view_manager_connection.cc (right):

https://codereview.chromium.org/290703002/diff/20001/mojo/services/view_manag...
mojo/services/view_manager/view_manager_connection.cc:124: if
(known_nodes_.find(NodeIdToTransportId(node->id())) !=
nit: use known_nodes_.count > 0 (it's shorter and what I've used throughout the
rest of this file).

[Ben Goodger (Google), 2014-05-16 23:34:14]

The CQ bit was checked by ben@chromium.org

[commit-bot: I haz the power, 2014-05-16 23:43:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ben@chromium.org/290703002/40001

[commit-bot: I haz the power, 2014-05-17 12:17:57]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[commit-bot: I haz the power, 2014-05-17 13:12:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-17 13:12:30]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[Ben Goodger (Google), 2014-05-19 18:25:11]

I had to update view_manager_connection_unittest.

There were a couple of tests relying on the fact that view-replaced
notifications were sent to all connections even if they didn't know about the
node having its view replaced.

[Ben Goodger (Google), 2014-05-19 21:43:07]

Committed patchset #4 manually as r271493 (presubmit successful).