Map new subtrees when they are attached to the node hierarchy visible to a connection.

mojo/services/view_manager/view_manager_connection.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/services/view_manager/view_manager_connection.h"
 
 #include "base/stl_util.h"
 #include "mojo/public/cpp/bindings/allocation_scope.h"
 #include "mojo/services/view_manager/node.h"
 #include "mojo/services/view_manager/root_node_manager.h"
@@ skipping 103 matching lines @@
                                    Array<INode>::From(to_send));
 }
 
 void ViewManagerConnection::ProcessNodeViewReplaced(
     const Node* node,
     const View* new_view,
     const View* old_view,
     bool originated_change) {
   if (originated_change)
     return;
-  const TransportViewId new_view_id = new_view ?
-      ViewIdToTransportId(new_view->id()) : 0;
-  const TransportViewId old_view_id = old_view ?
-      ViewIdToTransportId(old_view->id()) : 0;
-  client()->OnNodeViewReplaced(NodeIdToTransportId(node->id()),
-                               new_view_id, old_view_id);
+  if (known_nodes_.find(NodeIdToTransportId(node->id())) !=

[sky, 2014/05/16 23:28:22]

nit: use known_nodes_.count > 0 (it's shorter and what I've used throughout the
rest of this file).

+      known_nodes_.end()) {
+    const TransportViewId new_view_id = new_view ?
+        ViewIdToTransportId(new_view->id()) : 0;
+    const TransportViewId old_view_id = old_view ?
+        ViewIdToTransportId(old_view->id()) : 0;
+    client()->OnNodeViewReplaced(NodeIdToTransportId(node->id()),
+                                 new_view_id, old_view_id);
+  }
 }
 
 void ViewManagerConnection::ProcessNodeDeleted(
     const NodeId& node,
     TransportChangeId server_change_id,
     bool originated_change) {
   const bool in_known = known_nodes_.erase(NodeIdToTransportId(node)) > 0;
 
   if (originated_change)
     return;
@@ skipping 117 matching lines @@
 void ViewManagerConnection::CreateNode(
     TransportNodeId transport_node_id,
     const Callback<void(bool)>& callback) {
   const NodeId node_id(NodeIdFromTransportId(transport_node_id));
   if (node_id.connection_id != id_ ||
       node_map_.find(node_id.node_id) != node_map_.end()) {
     callback.Run(false);
     return;
   }
   node_map_[node_id.node_id] = new Node(this, node_id);
+  known_nodes_.insert(transport_node_id);
   callback.Run(true);
 }
 
 void ViewManagerConnection::DeleteNode(
     TransportNodeId transport_node_id,
     const Callback<void(bool)>& callback) {
   AllocationScope allocation_scope;
   const NodeId node_id(NodeIdFromTransportId(transport_node_id));
   ViewManagerConnection* connection = root_node_manager_->GetConnection(
       node_id.connection_id);
@@ skipping 108 matching lines @@
 
 void ViewManagerConnection::OnNodeViewReplaced(const Node* node,
                                                const View* new_view,
                                                const View* old_view) {
   root_node_manager_->ProcessNodeViewReplaced(node, new_view, old_view);
 }
 
 }  // namespace service
 }  // namespace view_manager
 }  // namespace mojo