Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2907023002: Revert of [Cronet] Build static libcronet.a for iOS with complete dependencies. (Closed)

Created:
3 years, 6 months ago by mef
Modified:
3 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, ios-reviews_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Cronet] Build static libcronet.a for iOS with complete dependencies. (patchset #20 id:380001 of https://codereview.chromium.org/2807283002/ ) Reason for revert: Broke official Cronet builders. Original issue's description: > [Cronet] Build static libcronet.a for iOS with complete dependencies. > > - Hide dependencies inside of the library to avoid symbol conflicts. > - Add cronet_consumer_static target that builds consumer app with static library. > > BUG=721922 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester > > Review-Url: https://codereview.chromium.org/2807283002 > Cr-Commit-Position: refs/heads/master@{#475158} > Committed: https://chromium.googlesource.com/chromium/src/+/3412c3c60b69798430b3a3cc9d2834f5d44e6042 TBR=ichikawa@chromium.org,kapishnikov@chromium.org,lilyhoughton@chromium.org,rsesek@chromium.org,jzw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=721922 Review-Url: https://codereview.chromium.org/2907023002 Cr-Commit-Position: refs/heads/master@{#475247} Committed: https://chromium.googlesource.com/chromium/src/+/14d16a8ffa51069ce25796ed7fa64df795b07d91

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -361 lines) Patch
M components/cronet/ios/BUILD.gn View 6 chunks +34 lines, -196 lines 0 comments Download
M components/cronet/ios/cronet_consumer/BUILD.gn View 1 chunk +18 lines, -51 lines 0 comments Download
D components/cronet/tools/dummy.py View 1 chunk +0 lines, -7 lines 0 comments Download
D components/cronet/tools/hide_symbols.py View 1 chunk +0 lines, -101 lines 0 comments Download
M components/cronet/tools/package_ios.py View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
mef
Created Revert of [Cronet] Build static libcronet.a for iOS with complete dependencies.
3 years, 6 months ago (2017-05-27 14:54:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2907023002/1
3 years, 6 months ago (2017-05-27 14:54:50 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-05-27 14:55:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/14d16a8ffa51069ce25796ed7fa6...

Powered by Google App Engine
This is Rietveld 408576698