Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2906993002: [i18n] about-sys to $i18n{} (Closed)

Created:
3 years, 6 months ago by dschuyler
Modified:
3 years, 6 months ago
Reviewers:
tommycli
CC:
chromium-reviews, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[i18n] about-sys to $i18n{} This CL changes i18n-content and i18n-values (the old way) to $i18n{} (the new way). BUG=677338 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2906993002 Cr-Commit-Position: refs/heads/master@{#476106} Committed: https://chromium.googlesource.com/chromium/src/+/f990567a85ba8196589a67de581fa2a5b16fae3e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M chrome/browser/resources/about_sys/about_sys.html View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
dschuyler
3 years, 6 months ago (2017-05-30 18:53:31 UTC) #7
tommycli
lgtm
3 years, 6 months ago (2017-05-30 18:59:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2906993002/1
3 years, 6 months ago (2017-05-30 20:30:30 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/306297)
3 years, 6 months ago (2017-05-30 23:45:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2906993002/1
3 years, 6 months ago (2017-05-31 21:04:05 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/227779)
3 years, 6 months ago (2017-05-31 22:48:44 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2906993002/1
3 years, 6 months ago (2017-06-01 00:13:22 UTC) #18
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 00:19:49 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f990567a85ba8196589a67de581f...

Powered by Google App Engine
This is Rietveld 408576698