DevTools: cleanup text input styles

DevTools: cleanup text input styles

We may want to land another CL to update text input styles:
https://codereview.chromium.org/2875193002/

BUG=690239
Review-Url: https://codereview.chromium.org/2906983002
Cr-Commit-Position: refs/heads/master@{#476487}
Committed: https://chromium.googlesource.com/chromium/src/+/13fb906c913d2886ecec2bb50b42f7d7629711f0

[luoe, 2017-05-26 23:13:53]

Patchset #1 (id:1) has been deleted

[luoe, 2017-05-26 23:19:46]

Description was changed from

==========
DevTools: normalize styles related to controls

BUG=690239
==========

to

==========
DevTools: cleanup text input styles

BUG=690239
==========

[luoe, 2017-05-26 23:30:15]

Description was changed from

==========
DevTools: cleanup text input styles

BUG=690239
==========

to

==========
DevTools: cleanup text input styles

We may want to land another CL to update text input styles:
https://codereview.chromium.org/2875193002/

BUG=690239
==========

[luoe, 2017-05-26 23:41:03]

luoe@chromium.org changed reviewers:
+ dgozman@chromium.org, einbinder@chromium.org, pfeldman@chromium.org

[luoe, 2017-05-26 23:41:04]

To make things easier to review, this CL was split out, and only affects <input>
text fields.

Please take a look

https://codereview.chromium.org/2906983002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/devices/devicesView.css
(left):

https://codereview.chromium.org/2906983002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/devices/devicesView.css:146:
overflow: hidden;
.port-forwarding-value applies to
- values in the port list
- text <input> used when adding a new port

Only the first case needs overflow hidden + ellipsis + etc.

https://codereview.chromium.org/2906983002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js
(right):

https://codereview.chromium.org/2906983002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js:89:
this._longitudeInput.setAttribute('step', 'any');
Without this, appropriate decimal values will invalidate the input, and
':invalid' will apply.

https://codereview.chromium.org/2906983002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js
(left):

https://codereview.chromium.org/2906983002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js:156:
titles.createChild('div', 'blocked-url-edit-value').textContent =
This element is help text that is constantly visible.  I think it's better not
to make this ellide.

This is the only noticeable visual change in this CL.

https://codereview.chromium.org/2906983002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/persistence/workspaceSettingsTab.css
(left):

https://codereview.chromium.org/2906983002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/persistence/workspaceSettingsTab.css:64:
}
A duplicate of these rules exists in settingsScreen.css

[pfeldman, 2017-05-31 21:51:15]

lgtm

https://codereview.chromium.org/2906983002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/emulation/sensors.css (right):

https://codereview.chromium.org/2906983002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/emulation/sensors.css:29: border:
1px solid #bfbfbf;
why does it have custom border?

https://codereview.chromium.org/2906983002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/settings/settingsScreen.css
(right):

https://codereview.chromium.org/2906983002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/settings/settingsScreen.css:165:
border: 1px solid rgb(213, 213, 213);
why does it have custom border?

https://codereview.chromium.org/2906983002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/searchableView.css (right):

https://codereview.chromium.org/2906983002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/searchableView.css:105:
.toolbar-search-control, input.toolbar-replace-control {
ditto

[luoe, 2017-06-01 01:10:44]

https://codereview.chromium.org/2906983002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/emulation/sensors.css (right):

https://codereview.chromium.org/2906983002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/emulation/sensors.css:29: border:
1px solid #bfbfbf;
On 2017/05/31 21:51:15, pfeldman wrote:
> why does it have custom border?

It's removed in the followup CL (https://codereview.chromium.org/2875193002).

Moving the border rule to a global input selector requires introducing a new
'default-input' class to exclude some exceptions (SSP filter, search fields,
toolbars).

https://codereview.chromium.org/2906983002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/settings/settingsScreen.css
(right):

https://codereview.chromium.org/2906983002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/settings/settingsScreen.css:165:
border: 1px solid rgb(213, 213, 213);
On 2017/05/31 21:51:15, pfeldman wrote:
> why does it have custom border?

Removed in next CL

https://codereview.chromium.org/2906983002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/searchableView.css (right):

https://codereview.chromium.org/2906983002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/searchableView.css:105:
.toolbar-search-control, input.toolbar-replace-control {
On 2017/05/31 21:51:15, pfeldman wrote:
> ditto

SearchableView's input fields are exceptions that won't inherit from the new
input styles, but keep their custom styles.

That said, I actually didn't need to add the 'input', so I'll remove that.

[pfeldman, 2017-06-01 21:09:11]

feel free to land...

[luoe, 2017-06-01 21:13:28]

The CQ bit was checked by luoe@chromium.org

[luoe, 2017-06-01 21:13:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2906983002/#ps40001
(title: "ac")

[commit-bot: I haz the power, 2017-06-01 21:14:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 23:55:11]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496351608148040,
"parent_rev": "192c7eb69acb5c3c7f3647777336941aca37cbe2", "commit_rev":
"13fb906c913d2886ecec2bb50b42f7d7629711f0"}

[commit-bot: I haz the power, 2017-06-01 23:55:20]

Description was changed from

==========
DevTools: cleanup text input styles

We may want to land another CL to update text input styles:
https://codereview.chromium.org/2875193002/

BUG=690239
==========

to

==========
DevTools: cleanup text input styles

We may want to land another CL to update text input styles:
https://codereview.chromium.org/2875193002/

BUG=690239

Review-Url: https://codereview.chromium.org/2906983002
Cr-Commit-Position: refs/heads/master@{#476487}
Committed:
https://chromium.googlesource.com/chromium/src/+/13fb906c913d2886ecec2bb50b42...
==========

[commit-bot: I haz the power, 2017-06-01 23:55:23]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/13fb906c913d2886ecec2bb50b42...