Upstream service wrkr "window client" test to WPT

Upstream service wrkr "window client" test to WPT

Re-locate test files to Web Platform Test directory for eventual
automated upstreaming.

The original version of this test registered a handler for the service
worker's "install" event after initial evaluation. Because this practice
is discouraged by the specification, it should be avoided. Re-factor the
test to immediately register the event handler and to preserve the
necessary behavior through an explicit message channel with the client.

Add a "use strict" directive to script bodies. Introduce a variable
declaration for a previously-undeclared binding. Correct a typo in an
error message. Ensure that each sub-test's asynchronous "cleanup" logic
is complete prior to advancing to the next sub-test.

BUG=688116
R=falken@chromium.org

Review-Url: https://codereview.chromium.org/2906963002
Cr-Commit-Position: refs/heads/master@{#475409}
Committed: https://chromium.googlesource.com/chromium/src/+/4d677eb1d7292c42d3902f28e2add76e9c65684d

[falken, 2017-05-29 04:54:08]

https://codereview.chromium.org/2906963002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/windowclient-navigate-worker.js
(right):

https://codereview.chromium.org/2906963002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/windowclient-navigate-worker.js:33:
var client, idx;
nit: idx -> i for consistency with above

https://codereview.chromium.org/2906963002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/windowclient-navigate-worker.js:35:
for (idx = 0; idx < client_list.length; ++idx) {
nit: ++idx -> i++ for consistency with above

https://codereview.chromium.org/2906963002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/windowclient-navigate.https.html
(right):

https://codereview.chromium.org/2906963002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/windowclient-navigate.https.html:118:
port.postMessage('');
why's this needed in cleanup? could we comment or perhaps the string could say
something to hint what it's doing?

https://codereview.chromium.org/2906963002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/windowclient-navigate.https.html:126:
var body = with_iframe(parameters.src_url)
Could we name this "test_promise" or something. "body" sounds to me like the
HTML body element.

https://codereview.chromium.org/2906963002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/windowclient-navigate.https.html:162:
// asynchronous operations at the time of this writing. Ensure also that
If there's a bug to link to about add_cleanup, it'd be good here.

[mike3, 2017-05-29 17:00:50]

Thanks, Matt!

https://codereview.chromium.org/2906963002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/windowclient-navigate-worker.js
(right):

https://codereview.chromium.org/2906963002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/windowclient-navigate-worker.js:33:
var client, idx;
On 2017/05/29 04:54:08, falken wrote:
> nit: idx -> i for consistency with above

Done.

https://codereview.chromium.org/2906963002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/windowclient-navigate-worker.js:35:
for (idx = 0; idx < client_list.length; ++idx) {
On 2017/05/29 04:54:08, falken wrote:
> nit: ++idx -> i++ for consistency with above

Done.

https://codereview.chromium.org/2906963002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/windowclient-navigate.https.html
(right):

https://codereview.chromium.org/2906963002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/windowclient-navigate.https.html:118:
port.postMessage('');
On 2017/05/29 04:54:08, falken wrote:
> why's this needed in cleanup? could we comment or perhaps the string could say
> something to hint what it's doing?

Done.

https://codereview.chromium.org/2906963002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/windowclient-navigate.https.html:126:
var body = with_iframe(parameters.src_url)
On 2017/05/29 04:54:08, falken wrote:
> Could we name this "test_promise" or something. "body" sounds to me like the
> HTML body element.

Done.

https://codereview.chromium.org/2906963002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/windowclient-navigate.https.html:162:
// asynchronous operations at the time of this writing. Ensure also that
On 2017/05/29 04:54:08, falken wrote:
> If there's a bug to link to about add_cleanup, it'd be good here.

There wasn't but there ought to have been.
https://github.com/w3c/web-platform-tests/issues/6075

[falken, 2017-05-30 01:11:01]

thanks, lgtm

https://codereview.chromium.org/2906963002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/windowclient-navigate.https.html
(right):

https://codereview.chromium.org/2906963002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/windowclient-navigate.https.html:124:
pausedLifecyclePort.postMessage('continue lifecycle');
Thanks for the comments and explanation!

[falken, 2017-05-30 01:11:44]

The CQ bit was checked by falken@chromium.org

[commit-bot: I haz the power, 2017-05-30 01:11:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 02:53:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496106704813220,
"parent_rev": "338bf607d38c8a0ace9dd2e0480cad386af2dc4e", "commit_rev":
"4d677eb1d7292c42d3902f28e2add76e9c65684d"}

[commit-bot: I haz the power, 2017-05-30 02:53:35]

Description was changed from

==========
Upstream service wrkr "window client" test to WPT

Re-locate test files to Web Platform Test directory for eventual
automated upstreaming.

The original version of this test registered a handler for the service
worker's "install" event after initial evaluation. Because this practice
is discouraged by the specification, it should be avoided. Re-factor the
test to immediately register the event handler and to preserve the
necessary behavior through an explicit message channel with the client.

Add a "use strict" directive to script bodies. Introduce a variable
declaration for a previously-undeclared binding. Correct a typo in an
error message. Ensure that each sub-test's asynchronous "cleanup" logic
is complete prior to advancing to the next sub-test.

BUG=688116
R=falken@chromium.org
==========

to

==========
Upstream service wrkr "window client" test to WPT

Re-locate test files to Web Platform Test directory for eventual
automated upstreaming.

The original version of this test registered a handler for the service
worker's "install" event after initial evaluation. Because this practice
is discouraged by the specification, it should be avoided. Re-factor the
test to immediately register the event handler and to preserve the
necessary behavior through an explicit message channel with the client.

Add a "use strict" directive to script bodies. Introduce a variable
declaration for a previously-undeclared binding. Correct a typo in an
error message. Ensure that each sub-test's asynchronous "cleanup" logic
is complete prior to advancing to the next sub-test.

BUG=688116
R=falken@chromium.org

Review-Url: https://codereview.chromium.org/2906963002
Cr-Commit-Position: refs/heads/master@{#475409}
Committed:
https://chromium.googlesource.com/chromium/src/+/4d677eb1d7292c42d3902f28e2ad...
==========

[commit-bot: I haz the power, 2017-05-30 02:53:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4d677eb1d7292c42d3902f28e2ad...