Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 2906933002: [gin] Remove the traces of crypto usage from gin (Closed)

Created:
3 years, 7 months ago by vivekg
Modified:
3 years, 6 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[gin] Remove the traces of crypto usage from gin The gin DEPS and BUILD.gn file lists crypto as a dependency but it's not used anywhere! So removing the traces of the crypto inclusion. The corresponding CL where the usage of crypto is removed can be found here: https://codereview.chromium.org/2103903002/ BUG=None R=jochen@chromium.org Review-Url: https://codereview.chromium.org/2906933002 Cr-Commit-Position: refs/heads/master@{#475509} Committed: https://chromium.googlesource.com/chromium/src/+/09d12909d7aea834c41bfcc455b15e30d27154e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M gin/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M gin/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M gin/v8_initializer.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
vivekg
PTAL
3 years, 7 months ago (2017-05-26 18:23:24 UTC) #5
vivekg
On 2017/05/26 18:23:24, vivekg wrote: > PTAL Gentle reminder!
3 years, 6 months ago (2017-05-30 10:16:25 UTC) #9
jochen (gone - plz use gerrit)
lgtm
3 years, 6 months ago (2017-05-30 11:48:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2906933002/1
3 years, 6 months ago (2017-05-30 11:59:36 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 13:10:07 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/09d12909d7aea834c41bfcc455b1...

Powered by Google App Engine
This is Rietveld 408576698