bluetooth: macOS: Remove c-style casting

bluetooth: macOS: Remove c-style casting

C-style casting should not be used in Chrome.

BUG=726754
Review-Url: https://codereview.chromium.org/2906923002
Cr-Commit-Position: refs/heads/master@{#475103}
Committed: https://chromium.googlesource.com/chromium/src/+/4cb09047752e7674538e804c565f2a6b66920dae

[jlebel, 2017-05-26 16:57:44]

Description was changed from

==========
Remove c-style casting

BUG=726754
==========

to

==========
bluetooth: macOS: Remove c-style casting

BUG=726754
==========

[jlebel, 2017-05-26 16:58:56]

jlebel@chromium.org changed reviewers:
+ ortuno@chromium.org

[jlebel, 2017-05-26 16:58:56]

Hello Giovanni,

Can you review this patch about c-style casting?

Thanks,

[ortuno, 2017-05-26 17:03:03]

lgtm, though could you make the description more detailed i.e. why are we
removing c-style casting. It's just to help someone looking back know the reason
for the patch.

[ortuno, 2017-05-26 17:03:30]

also please make sure you are running device_unittests as we can't trust the CQ
with mac patches.

[jlebel, 2017-05-26 17:06:24]

Description was changed from

==========
bluetooth: macOS: Remove c-style casting

BUG=726754
==========

to

==========
bluetooth: macOS: Remove c-style casting

C-style casting should not be used in Chrome.

BUG=726754
==========

[jlebel, 2017-05-26 17:07:44]

The CQ bit was checked by jlebel@chromium.org

[commit-bot: I haz the power, 2017-05-26 17:08:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 18:22:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 18:22:50]

Failed to apply patch for device/bluetooth/bluetooth_remote_gatt_service_mac.mm:
While running git apply --index -3 -p1;
  error: patch failed: device/bluetooth/bluetooth_remote_gatt_service_mac.mm:28
  Falling back to three-way merge...
  Applied patch to 'device/bluetooth/bluetooth_remote_gatt_service_mac.mm' with
conflicts.
  U device/bluetooth/bluetooth_remote_gatt_service_mac.mm

Patch:       device/bluetooth/bluetooth_remote_gatt_service_mac.mm
Index: device/bluetooth/bluetooth_remote_gatt_service_mac.mm
diff --git a/device/bluetooth/bluetooth_remote_gatt_service_mac.mm
b/device/bluetooth/bluetooth_remote_gatt_service_mac.mm
index
5fdf6741f9a691c98fc4497b0cb6168cca3894a6..0e01d0c59b12d86e57372aa8efb33d231a38ec17
100644
--- a/device/bluetooth/bluetooth_remote_gatt_service_mac.mm
+++ b/device/bluetooth/bluetooth_remote_gatt_service_mac.mm
@@ -28,7 +28,7 @@ BluetoothRemoteGattServiceMac::BluetoothRemoteGattServiceMac(
   uuid_ = BluetoothAdapterMac::BluetoothUUIDWithCBUUID([service_.get() UUID]);
   identifier_ =
       [NSString stringWithFormat:@"%s-%p", uuid_.canonical_value().c_str(),
-                                 (void*)service_]
+                                 service_.get()]
           .UTF8String;
 }

[jlebel, 2017-05-26 18:27:25]

The CQ bit was checked by jlebel@chromium.org

[jlebel, 2017-05-26 18:27:26]

The patchset sent to the CQ was uploaded after l-g-t-m from ortuno@chromium.org
Link to the patchset: https://codereview.chromium.org/2906923002/#ps20001
(title: "Merge from top of tree")

[commit-bot: I haz the power, 2017-05-26 18:28:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 20:15:01]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495823245492170,
"parent_rev": "4e606243eebf4e76d2c35f5064606c346da5b586", "commit_rev":
"4cb09047752e7674538e804c565f2a6b66920dae"}

[commit-bot: I haz the power, 2017-05-26 20:15:18]

Description was changed from

==========
bluetooth: macOS: Remove c-style casting

C-style casting should not be used in Chrome.

BUG=726754
==========

to

==========
bluetooth: macOS: Remove c-style casting

C-style casting should not be used in Chrome.

BUG=726754

Review-Url: https://codereview.chromium.org/2906923002
Cr-Commit-Position: refs/heads/master@{#475103}
Committed:
https://chromium.googlesource.com/chromium/src/+/4cb09047752e7674538e804c565f...
==========

[commit-bot: I haz the power, 2017-05-26 20:15:19]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4cb09047752e7674538e804c565f...