Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2906923002: bluetooth: macOS: Remove c-style casting (Closed)

Created:
3 years, 7 months ago by jlebel
Modified:
3 years, 6 months ago
Reviewers:
ortuno
CC:
chromium-reviews, mac-reviews_chromium.org, ortuno+watch_chromium.org, scheib+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: macOS: Remove c-style casting C-style casting should not be used in Chrome. BUG=726754 Review-Url: https://codereview.chromium.org/2906923002 Cr-Commit-Position: refs/heads/master@{#475103} Committed: https://chromium.googlesource.com/chromium/src/+/4cb09047752e7674538e804c565f2a6b66920dae

Patch Set 1 #

Patch Set 2 : Merge from top of tree #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M device/bluetooth/bluetooth_adapter_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_descriptor_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_service_mac.mm View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
jlebel
Hello Giovanni, Can you review this patch about c-style casting? Thanks,
3 years, 7 months ago (2017-05-26 16:58:56 UTC) #3
ortuno
lgtm, though could you make the description more detailed i.e. why are we removing c-style ...
3 years, 7 months ago (2017-05-26 17:03:03 UTC) #4
ortuno
also please make sure you are running device_unittests as we can't trust the CQ with ...
3 years, 7 months ago (2017-05-26 17:03:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2906923002/1
3 years, 7 months ago (2017-05-26 17:08:18 UTC) #8
commit-bot: I haz the power
Failed to apply patch for device/bluetooth/bluetooth_remote_gatt_service_mac.mm: While running git apply --index -3 -p1; error: patch ...
3 years, 7 months ago (2017-05-26 18:22:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2906923002/20001
3 years, 7 months ago (2017-05-26 18:28:02 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-05-26 20:15:19 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4cb09047752e7674538e804c565f...

Powered by Google App Engine
This is Rietveld 408576698