chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h - Issue 2906893004: Omnibox UI Experiments: Port Vertical Layout experiment to Mac Cocoa.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h

Issue 2906893004: Omnibox UI Experiments: Port Vertical Layout experiment to Mac Cocoa. (Closed)

Patch Set: fix camel case Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h

diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h

index 21ba3089c5ecd0d8ab774979515b2d88953f2b34..fc1f36d55b51dcbc70db9e618abba9afb782f329 100644

--- a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h

+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h

@@ -68,7 +68,7 @@ class OmniboxPopupViewMac;

+ (CGFloat)getContentAreaWidth:(NSRect)cellFrame;

-+ (CGFloat)getContentTextHeight;

++ (CGFloat)getContentTextHeight:(BOOL)isTwoLine;

groby-ooo-7-16 2017/05/31 00:14:51 Goal for cocoa functions is usually to be readable

tommycli 2017/05/31 18:20:39 Done.

@end