Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: chrome/browser/resources/settings/printing_page/cups_printers_list.html

Issue 2906893003: Settings: Printers: Cleanup layout and fix for long names (Closed)
Patch Set: Use list-frame instead of underbar Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/printing_page/cups_printers_list.html
diff --git a/chrome/browser/resources/settings/printing_page/cups_printers_list.html b/chrome/browser/resources/settings/printing_page/cups_printers_list.html
index 76c891aeb4dbaf728256f565feac88b4bf8471f9..578b48c8ab1302abc275661aa8e066e609f21ace 100644
--- a/chrome/browser/resources/settings/printing_page/cups_printers_list.html
+++ b/chrome/browser/resources/settings/printing_page/cups_printers_list.html
@@ -9,19 +9,8 @@
<dom-module id="settings-cups-printers-list">
<template>
<style include="settings-shared">
- #container {
- border-top: 1px solid lightgray;
- display: flex;
- padding: 2px 20px;
- }
-
- .name-column {
+ .printer-name {
flex: 1;
- margin: 2px;
- }
-
- .list-item {
- min-height: 20px;
}
</style>
@@ -33,18 +22,18 @@
$i18n{removePrinter}
</button>
</dialog>
- <template is="dom-repeat" items="[[printers]]"
- filter="[[filterPrinter_(searchTerm)]]">
- <div id="container" class="list-item">
- <div class="name-column">
- <span class="name" id="printer-name">[[item.printerName]]</span>
+ <div class="list-frame vertical-list">
+ <template is="dom-repeat" items="[[printers]]"
+ filter="[[filterPrinter_(searchTerm)]]">
+ <div class="list-item">
+ <div class="printer-name text-elide">[[item.printerName]]</div>
<!--TODO(xdai): Add icon for enterprise CUPS printer. -->
+ <paper-icon-button icon="cr:more-vert" on-tap="onOpenActionMenuTap_"
+ title="$i18n{moreActions}">
+ </paper-icon-button>
</div>
- <paper-icon-button icon="cr:more-vert" on-tap="onOpenActionMenuTap_"
- title="$i18n{moreActions}">
- </paper-icon-button>
- </div>
- </template>
+ </template
+ </div>
</template>
<script src="cups_printers_list.js"></script>
</dom-module>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698