Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Side by Side Diff: chrome/browser/resources/settings/printing_page/cups_printers_list.html

Issue 2906893003: Settings: Printers: Cleanup layout and fix for long names (Closed)
Patch Set: Use list-frame instead of underbar Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 2
3 <link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action _menu.html"> 3 <link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action _menu.html">
4 <link rel="import" href="chrome://resources/cr_elements/icons.html"> 4 <link rel="import" href="chrome://resources/cr_elements/icons.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
6 <link rel="import" href="cups_printers_browser_proxy.html"> 6 <link rel="import" href="cups_printers_browser_proxy.html">
7 <link rel="import" href="../settings_shared_css.html"> 7 <link rel="import" href="../settings_shared_css.html">
8 8
9 <dom-module id="settings-cups-printers-list"> 9 <dom-module id="settings-cups-printers-list">
10 <template> 10 <template>
11 <style include="settings-shared"> 11 <style include="settings-shared">
12 #container { 12 .printer-name {
13 border-top: 1px solid lightgray;
14 display: flex;
15 padding: 2px 20px;
16 }
17
18 .name-column {
19 flex: 1; 13 flex: 1;
20 margin: 2px;
21 }
22
23 .list-item {
24 min-height: 20px;
25 } 14 }
26 </style> 15 </style>
27 16
28 <dialog is="cr-action-menu"> 17 <dialog is="cr-action-menu">
29 <button class="dropdown-item" role="option" on-tap="onDetailsTap_"> 18 <button class="dropdown-item" role="option" on-tap="onDetailsTap_">
30 $i18n{cupsPrinterDetails} 19 $i18n{cupsPrinterDetails}
31 </button> 20 </button>
32 <button class="dropdown-item" role="option" on-tap="onRemoveTap_"> 21 <button class="dropdown-item" role="option" on-tap="onRemoveTap_">
33 $i18n{removePrinter} 22 $i18n{removePrinter}
34 </button> 23 </button>
35 </dialog> 24 </dialog>
36 <template is="dom-repeat" items="[[printers]]" 25 <div class="list-frame vertical-list">
37 filter="[[filterPrinter_(searchTerm)]]"> 26 <template is="dom-repeat" items="[[printers]]"
38 <div id="container" class="list-item"> 27 filter="[[filterPrinter_(searchTerm)]]">
39 <div class="name-column"> 28 <div class="list-item">
40 <span class="name" id="printer-name">[[item.printerName]]</span> 29 <div class="printer-name text-elide">[[item.printerName]]</div>
41 <!--TODO(xdai): Add icon for enterprise CUPS printer. --> 30 <!--TODO(xdai): Add icon for enterprise CUPS printer. -->
31 <paper-icon-button icon="cr:more-vert" on-tap="onOpenActionMenuTap_"
32 title="$i18n{moreActions}">
33 </paper-icon-button>
42 </div> 34 </div>
43 <paper-icon-button icon="cr:more-vert" on-tap="onOpenActionMenuTap_" 35 </template
44 title="$i18n{moreActions}"> 36 </div>
45 </paper-icon-button>
46 </div>
47 </template>
48 </template> 37 </template>
49 <script src="cups_printers_list.js"></script> 38 <script src="cups_printers_list.js"></script>
50 </dom-module> 39 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698