bluetooth: macOS: Removing useless |.get()|

bluetooth: macOS: Removing useless |.get()|

Changing `object.get().value` to `[object value]`. ObjC dot notation for NSObjects
in Chrome should not be used (only for structs like NSSize).
And removing some other useless .get().

BUG=709104
Review-Url: https://codereview.chromium.org/2906883004
Cr-Commit-Position: refs/heads/master@{#475092}
Committed: https://chromium.googlesource.com/chromium/src/+/35be3092e0e4591024a4d3fa47b00160d3da1f79

[jlebel, 2017-05-26 16:22:51]

Patchset #1 (id:1) has been deleted

[jlebel, 2017-05-26 16:23:19]

jlebel@chromium.org changed reviewers:
+ ortuno@chromium.org

[jlebel, 2017-05-26 16:23:19]

Hello Giovanni,

Can you review this patch?

Thanks,

[ortuno, 2017-05-26 16:33:02]

Could you make the description more detailed e.g.

We don't use ObjC dot notation for NSObjects in Chrome (only for structs like
NSSize).
Changes `cb_descriptor_.get().value` to `[cb_descriptor_ value]` so it's clear
this is an ObjC message send.

https://codereview.chromium.org/2906883004/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_adapter_mac_unittest.mm (right):

https://codereview.chromium.org/2906883004/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_adapter_mac_unittest.mm:103:
(CBCentralManager*)(mock_central_manager_.get());
Do we have an issue to get rid of c-style casting?

[ortuno, 2017-05-26 16:33:08]

Also lgtm

[jlebel, 2017-05-26 16:47:38]

Description was changed from

==========
Removing useless |.get()|

BUG=709104
==========

to

==========
Removing useless |.get()|

Changing `object.get().value` to `[object value]`. And removing some other
useless .get().

BUG=709104
==========

[jlebel, 2017-05-26 16:51:15]

https://codereview.chromium.org/2906883004/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_adapter_mac_unittest.mm (right):

https://codereview.chromium.org/2906883004/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_adapter_mac_unittest.mm:103:
(CBCentralManager*)(mock_central_manager_.get());
On 2017/05/26 16:33:02, ortuno wrote:
> Do we have an issue to get rid of c-style casting?

No, but I'm working on that one right now. I didn't mean to touch it in this
patch.

[jlebel, 2017-05-26 17:05:59]

Description was changed from

==========
Removing useless |.get()|

Changing `object.get().value` to `[object value]`. And removing some other
useless .get().

BUG=709104
==========

to

==========
Removing useless |.get()|

Changing `object.get().value` to `[object value]`. ObjC dot notation for
NSObjects
in Chrome should not be used (only for structs like NSSize).
And removing some other useless .get().

BUG=709104
==========

[jlebel, 2017-05-26 18:31:14]

The CQ bit was checked by jlebel@chromium.org

[jlebel, 2017-05-26 18:31:14]

The patchset sent to the CQ was uploaded after l-g-t-m from ortuno@chromium.org
Link to the patchset: https://codereview.chromium.org/2906883004/#ps60001
(title: "Merge from top of tree")

[commit-bot: I haz the power, 2017-05-26 18:32:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jlebel, 2017-05-26 18:41:16]

Description was changed from

==========
Removing useless |.get()|

Changing `object.get().value` to `[object value]`. ObjC dot notation for
NSObjects
in Chrome should not be used (only for structs like NSSize).
And removing some other useless .get().

BUG=709104
==========

to

==========
bluetooth: macOS: Removing useless |.get()|

Changing `object.get().value` to `[object value]`. ObjC dot notation for
NSObjects
in Chrome should not be used (only for structs like NSSize).
And removing some other useless .get().

BUG=709104
==========

[commit-bot: I haz the power, 2017-05-26 19:55:37]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495823474118630,
"parent_rev": "6c6d330b4952c018fd8a59df156bc3dba612a1dc", "commit_rev":
"35be3092e0e4591024a4d3fa47b00160d3da1f79"}

[commit-bot: I haz the power, 2017-05-26 19:55:52]

Description was changed from

==========
bluetooth: macOS: Removing useless |.get()|

Changing `object.get().value` to `[object value]`. ObjC dot notation for
NSObjects
in Chrome should not be used (only for structs like NSSize).
And removing some other useless .get().

BUG=709104
==========

to

==========
bluetooth: macOS: Removing useless |.get()|

Changing `object.get().value` to `[object value]`. ObjC dot notation for
NSObjects
in Chrome should not be used (only for structs like NSSize).
And removing some other useless .get().

BUG=709104

Review-Url: https://codereview.chromium.org/2906883004
Cr-Commit-Position: refs/heads/master@{#475092}
Committed:
https://chromium.googlesource.com/chromium/src/+/35be3092e0e4591024a4d3fa47b0...
==========

[commit-bot: I haz the power, 2017-05-26 19:55:53]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/35be3092e0e4591024a4d3fa47b0...