Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 2906873003: chromeos: turn on simplified display management for mash (Closed)

Created:
3 years, 6 months ago by sky
Modified:
3 years, 6 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: turn on simplified display management for mash I'm going to keep the function to determine if enabled. Assuming there aren't any issues after a couple of days I'll do a cleanup pass. BUG=718860 TEST=none R=msw@chromium.org Review-Url: https://codereview.chromium.org/2906873003 Cr-Commit-Position: refs/heads/master@{#477150} Committed: https://chromium.googlesource.com/chromium/src/+/2c5eae86eddc741f7619898863ab70d89a29f39e

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : moar #

Total comments: 4

Patch Set 4 : merge and remove unneeded #

Patch Set 5 : update tests #

Patch Set 6 : really disable failing tests #

Total comments: 6

Patch Set 7 : bug refs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -301 lines) Patch
M ash/mus/BUILD.gn View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M ash/mus/bridge/shell_port_mash.cc View 1 2 3 14 chunks +16 lines, -25 lines 0 comments Download
D ash/mus/screen_mus_unittest.cc View 1 2 3 4 1 chunk +0 lines, -53 lines 0 comments Download
M ash/mus/window_manager.cc View 1 2 3 2 chunks +3 lines, -5 lines 0 comments Download
M ash/mus/window_manager_application.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ash/rotator/screen_rotation_animator_unittest.cc View 1 2 3 4 5 6 16 chunks +12 lines, -102 lines 0 comments Download
M ash/shell.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M ash/shell.cc View 1 2 3 4 5 6 11 chunks +23 lines, -18 lines 0 comments Download
M ash/test/ash_test_base.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/test/ash_test_helper.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/BUILD.gn View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 2 3 2 chunks +7 lines, -15 lines 0 comments Download
D chrome/browser/chromeos/dbus/mus_console_service_provider_delegate.h View 1 2 3 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/chromeos/dbus/mus_console_service_provider_delegate.cc View 1 2 3 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 27 (18 generated)
sky
3 years, 6 months ago (2017-05-26 15:24:17 UTC) #1
msw
It's not entirely obvious what's correct in each case (maybe some old MUS-only paths shouldn't ...
3 years, 6 months ago (2017-05-26 16:38:50 UTC) #6
sky
https://codereview.chromium.org/2906873003/diff/40001/ash/test/ash_test_helper.cc File ash/test/ash_test_helper.cc (right): https://codereview.chromium.org/2906873003/diff/40001/ash/test/ash_test_helper.cc#newcode183 ash/test/ash_test_helper.cc:183: // TODO(sky): mash should use this too http://crbug.com/718860. On ...
3 years, 6 months ago (2017-06-05 17:19:44 UTC) #9
sky
I had to do some other changes to get this working (and land a few ...
3 years, 6 months ago (2017-06-05 22:37:40 UTC) #17
msw
This still lgtm with nits/q the caveat that it's still not entirely obvious to me ...
3 years, 6 months ago (2017-06-05 23:05:05 UTC) #19
sky
On 2017/06/05 23:05:05, msw wrote: > This still lgtm with nits/q the caveat that it's ...
3 years, 6 months ago (2017-06-05 23:29:37 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2906873003/120001
3 years, 6 months ago (2017-06-05 23:30:29 UTC) #23
sky
https://codereview.chromium.org/2906873003/diff/100001/ash/mus/screen_mus_unittest.cc File ash/mus/screen_mus_unittest.cc (left): https://codereview.chromium.org/2906873003/diff/100001/ash/mus/screen_mus_unittest.cc#oldcode16 ash/mus/screen_mus_unittest.cc:16: class ScreenMusTest : public AshTestBase { On 2017/06/05 23:05:04, ...
3 years, 6 months ago (2017-06-06 00:04:22 UTC) #24
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 01:47:12 UTC) #27
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/2c5eae86eddc741f7619898863ab...

Powered by Google App Engine
This is Rietveld 408576698