Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2906853004: DevTools: stop hideOnDetach for Audits (Closed)

Created:
3 years, 6 months ago by luoe
Modified:
3 years, 6 months ago
Reviewers:
paulirish, dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: stop hideOnDetach for Audits The new Audits panel calls hideOnDetach. This allows iframes within to run uninterrupted when switching to another panel. An unwanted side effect of keeping it in the DOM is that its stylesheets will apply to other panels. Today, Audits no longer has iframes inside, so this is not needed anymore. BUG=726926 Review-Url: https://codereview.chromium.org/2906853004 Cr-Commit-Position: refs/heads/master@{#475235} Committed: https://chromium.googlesource.com/chromium/src/+/fb9004bf71f341d4a072f4d83ef3431a36e31250

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
luoe
Please take a look
3 years, 6 months ago (2017-05-26 23:59:24 UTC) #3
paulirish
confirm. we don't need this any longer.
3 years, 6 months ago (2017-05-27 00:23:30 UTC) #4
paulirish
lgtm
3 years, 6 months ago (2017-05-27 00:23:32 UTC) #5
dgozman
lgtm
3 years, 6 months ago (2017-05-27 01:07:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2906853004/1
3 years, 6 months ago (2017-05-27 02:39:34 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-05-27 04:21:08 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fb9004bf71f341d4a072f4d83ef3...

Powered by Google App Engine
This is Rietveld 408576698