Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2906813002:
Remove Compositing.LayerTreeImpl.FindClosestMatchingLayerUs histogram (Closed)
DescriptionRemove Compositing.LayerTreeImpl.FindClosestMatchingLayerUs histogram
This histogram was added when the logic of finding closest matching
layers was changed to ensure we din't regress. The old logic is on M-57
and the new one is in M-58. Looking at the numbers we have actually
improved and this histogram is no longer needed.
Mean time in M-57 on Android : 74 microseconds
Mean time in M-58 on Android : 59 microseconds
BUG=710306
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Review-Url: https://codereview.chromium.org/2906813002
Cr-Commit-Position: refs/heads/master@{#475214}
Committed: https://chromium.googlesource.com/chromium/src/+/9963b64bffbccabb05118813832442b9ac1a437c
Patch Set 1 #
Total comments: 2
Patch Set 2 : Rebase , comments #
Messages
Total messages: 22 (11 generated)
Description was changed from ========== Remove Compositing.LayerTreeImpl.FindClosestMatchingLayerUs histogram This histogram was added to when the logic of finding closest matching layers was changed to ensure we din't regress. The old logic is on M-57 and the new one is in M-58. Looking at the numbers we have actually improved and this histogram is no longer needed. Mean time in M-57 on Android : 74 microseconds Mean time in M-58 on Android : 59 microseconds BUG=722656 ========== to ========== Remove Compositing.LayerTreeImpl.FindClosestMatchingLayerUs histogram This histogram was added to when the logic of finding closest matching layers was changed to ensure we din't regress. The old logic is on M-57 and the new one is in M-58. Looking at the numbers we have actually improved and this histogram is no longer needed. Mean time in M-57 on Android : 74 microseconds Mean time in M-58 on Android : 59 microseconds BUG=722656 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
jaydasika@chromium.org changed reviewers: + danakj@chromium.org, weiliangc@chromium.org
PTAL
Description was changed from ========== Remove Compositing.LayerTreeImpl.FindClosestMatchingLayerUs histogram This histogram was added to when the logic of finding closest matching layers was changed to ensure we din't regress. The old logic is on M-57 and the new one is in M-58. Looking at the numbers we have actually improved and this histogram is no longer needed. Mean time in M-57 on Android : 74 microseconds Mean time in M-58 on Android : 59 microseconds BUG=722656 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== Remove Compositing.LayerTreeImpl.FindClosestMatchingLayerUs histogram This histogram was added when the logic of finding closest matching layers was changed to ensure we din't regress. The old logic is on M-57 and the new one is in M-58. Looking at the numbers we have actually improved and this histogram is no longer needed. Mean time in M-57 on Android : 74 microseconds Mean time in M-58 on Android : 59 microseconds BUG=722656 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
Description was changed from ========== Remove Compositing.LayerTreeImpl.FindClosestMatchingLayerUs histogram This histogram was added when the logic of finding closest matching layers was changed to ensure we din't regress. The old logic is on M-57 and the new one is in M-58. Looking at the numbers we have actually improved and this histogram is no longer needed. Mean time in M-57 on Android : 74 microseconds Mean time in M-58 on Android : 59 microseconds BUG=722656 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== Remove Compositing.LayerTreeImpl.FindClosestMatchingLayerUs histogram This histogram was added when the logic of finding closest matching layers was changed to ensure we din't regress. The old logic is on M-57 and the new one is in M-58. Looking at the numbers we have actually improved and this histogram is no longer needed. Mean time in M-57 on Android : 74 microseconds Mean time in M-58 on Android : 59 microseconds BUG=710306 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
LGTM % wei
lgtm
The CQ bit was checked by jaydasika@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
jaydasika@chromium.org changed reviewers: + isherman@chromium.org
isherman : Please review changes to histograms.xml
Thanks for the cleanup! https://codereview.chromium.org/2906813002/diff/1/tools/metrics/histograms/hi... File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/2906813002/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:8206: - units="microseconds"> Please mark this histogram as <obsolete> rather than removing its metadata.
https://codereview.chromium.org/2906813002/diff/1/tools/metrics/histograms/hi... File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/2906813002/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:8206: - units="microseconds"> On 2017/05/26 22:20:36, Ilya Sherman wrote: > Please mark this histogram as <obsolete> rather than removing its metadata. Done.
histograms.xml lgtm, thanks
The CQ bit was checked by jaydasika@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org, weiliangc@chromium.org Link to the patchset: https://codereview.chromium.org/2906813002/#ps20001 (title: "Rebase , comments")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495838622345290,
"parent_rev": "46d59d4b14841bdc82c24ad95d2c446fd508fdb4", "commit_rev":
"9963b64bffbccabb05118813832442b9ac1a437c"}
Message was sent while issue was closed.
Description was changed from ========== Remove Compositing.LayerTreeImpl.FindClosestMatchingLayerUs histogram This histogram was added when the logic of finding closest matching layers was changed to ensure we din't regress. The old logic is on M-57 and the new one is in M-58. Looking at the numbers we have actually improved and this histogram is no longer needed. Mean time in M-57 on Android : 74 microseconds Mean time in M-58 on Android : 59 microseconds BUG=710306 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== Remove Compositing.LayerTreeImpl.FindClosestMatchingLayerUs histogram This histogram was added when the logic of finding closest matching layers was changed to ensure we din't regress. The old logic is on M-57 and the new one is in M-58. Looking at the numbers we have actually improved and this histogram is no longer needed. Mean time in M-57 on Android : 74 microseconds Mean time in M-58 on Android : 59 microseconds BUG=710306 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2906813002 Cr-Commit-Position: refs/heads/master@{#475214} Committed: https://chromium.googlesource.com/chromium/src/+/9963b64bffbccabb051188138324... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/9963b64bffbccabb051188138324... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
