Milo: Fix swarmbucket kitchen crashes

Milo: Fix swarmbucket kitchen crashes

Currently if kitchen crashes, then Milo shows pending because it's waiting for a
logdog stream (that would never appear).  This fixes this case, and draws out
the stats from the swarming job instead.

BUG=697661
Review-Url: https://codereview.chromium.org/2906753003
Committed: https://github.com/luci/luci-go/commit/d06ec5035c609eb030e20b470ce6ceeb0d7f428c

[Ryan Tseng, 2017-05-25 21:08:42]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 21:08:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Tseng, 2017-05-25 21:10:24]

hinoka@google.com changed reviewers:
+ nodir@chromium.org

[Ryan Tseng, 2017-05-25 21:10:25]

I don't have a sample of this on a dev server, so no example link this time, but
there's an example expectation.

[commit-bot: I haz the power, 2017-05-25 21:10:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 21:10:57]

Dry run: Try jobs failed on following builders:
  Luci-go Mac Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/365a435b592d5b10)

[nodir, 2017-05-25 21:32:42]

lgtm

https://codereview.chromium.org/2906753003/diff/1/milo/appengine/swarming/bui...
File milo/appengine/swarming/build.go (right):

https://codereview.chromium.org/2906753003/diff/1/milo/appengine/swarming/bui...
milo/appengine/swarming/build.go:542: build.Summary.Started, err =
time.Parse(time.RFC3339Nano, res.StartedTs+"Z")
i think SwarmingTimeLayout should be used here

https://codereview.chromium.org/2906753003/diff/1/milo/appengine/swarming/bui...
milo/appengine/swarming/build.go:546: build.Summary.Finished, err =
time.Parse(time.RFC3339Nano, res.CompletedTs+"Z")
here too

https://codereview.chromium.org/2906753003/diff/1/milo/appengine/swarming/bui...
milo/appengine/swarming/build.go:635: if fr.res.State == "COMPLETED" {
use TaskCompleted const

[Ryan Tseng, 2017-05-25 21:35:55]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 21:35:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Tseng, 2017-05-25 21:37:02]

https://codereview.chromium.org/2906753003/diff/1/milo/appengine/swarming/bui...
File milo/appengine/swarming/build.go (right):

https://codereview.chromium.org/2906753003/diff/1/milo/appengine/swarming/bui...
milo/appengine/swarming/build.go:542: build.Summary.Started, err =
time.Parse(time.RFC3339Nano, res.StartedTs+"Z")
On 2017/05/25 21:32:42, nodir wrote:
> i think SwarmingTimeLayout should be used here

Done.

https://codereview.chromium.org/2906753003/diff/1/milo/appengine/swarming/bui...
milo/appengine/swarming/build.go:546: build.Summary.Finished, err =
time.Parse(time.RFC3339Nano, res.CompletedTs+"Z")
On 2017/05/25 21:32:42, nodir wrote:
> here too

Done.

https://codereview.chromium.org/2906753003/diff/1/milo/appengine/swarming/bui...
milo/appengine/swarming/build.go:635: if fr.res.State == "COMPLETED" {
On 2017/05/25 21:32:42, nodir wrote:
> use TaskCompleted const

Done.

[Ryan Tseng, 2017-05-25 21:37:05]

The CQ bit was unchecked by hinoka@google.com

[Ryan Tseng, 2017-05-25 21:37:07]

The CQ bit was checked by hinoka@google.com

[Ryan Tseng, 2017-05-25 21:37:08]

The patchset sent to the CQ was uploaded after l-g-t-m from nodir@chromium.org
Link to the patchset: https://codereview.chromium.org/2906753003/#ps20001
(title: "Review")

[commit-bot: I haz the power, 2017-05-25 21:37:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 21:44:19]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495748227942060,
"parent_rev": "8f9ef0bee3bc616811ad9969513be3871aea94cd", "commit_rev":
"d06ec5035c609eb030e20b470ce6ceeb0d7f428c"}

[commit-bot: I haz the power, 2017-05-25 21:44:22]

Description was changed from

==========
Milo: Fix swarmbucket kitchen crashes

Currently if kitchen crashes, then Milo shows pending because it's waiting for a
logdog stream (that would never appear).  This fixes this case, and draws out
the stats from the swarming job instead.

BUG=697661
==========

to

==========
Milo: Fix swarmbucket kitchen crashes

Currently if kitchen crashes, then Milo shows pending because it's waiting for a
logdog stream (that would never appear).  This fixes this case, and draws out
the stats from the swarming job instead.

BUG=697661

Review-Url: https://codereview.chromium.org/2906753003
Committed:
https://github.com/luci/luci-go/commit/d06ec5035c609eb030e20b470ce6ceeb0d7f428c
==========

[commit-bot: I haz the power, 2017-05-25 21:44:23]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/d06ec5035c609eb030e20b470ce6ceeb0d7f428c