Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2906753002: VR: Setting background colors for URL bar (Closed)

Created:
3 years, 7 months ago by acondor_
Modified:
3 years, 7 months ago
Reviewers:
cjgrant
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

VR: Setting background colors for URL bar Includes hover and click state for back button. BUG= Review-Url: https://codereview.chromium.org/2906753002 Cr-Commit-Position: refs/heads/master@{#474850} Committed: https://chromium.googlesource.com/chromium/src/+/b854fac00a98fe03050b5ab5984e4f07ac49c99c

Patch Set 1 #

Patch Set 2 : adjust hover/click #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/browser/android/vr_shell/textures/url_bar_texture.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (4 generated)
acondor_
PTAL
3 years, 7 months ago (2017-05-25 21:50:18 UTC) #2
cjgrant
lgtm
3 years, 7 months ago (2017-05-25 22:25:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2906753002/20001
3 years, 7 months ago (2017-05-25 22:28:12 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 00:23:18 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b854fac00a98fe03050b5ab5984e...

Powered by Google App Engine
This is Rietveld 408576698