Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issue 2906693005: [Chromedriver] Disable tests involving AddCookie on WebView shell. (Closed)

Created:
3 years, 6 months ago by gmanikpure
Modified:
3 years, 6 months ago
Reviewers:
johnchen, stgao
CC:
chromium-reviews, johnchen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromedriver] Disable tests involving AddCookie on WebView shell. BUG= Review-Url: https://codereview.chromium.org/2906693005 Cr-Commit-Position: refs/heads/master@{#476092} Committed: https://chromium.googlesource.com/chromium/src/+/6db567c03673972649d58ab0c088ad24b8742ab0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/test/chromedriver/test/run_py_tests.py View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
gmanikpure
Could you please take a look? Thanks.
3 years, 6 months ago (2017-05-26 21:37:11 UTC) #2
johnchen
lgtm
3 years, 6 months ago (2017-05-31 17:28:35 UTC) #3
gmanikpure
Shuotao, Could you please approve this CL? Thanks.
3 years, 6 months ago (2017-05-31 23:16:52 UTC) #4
stgao
lgtm
3 years, 6 months ago (2017-05-31 23:27:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2906693005/1
3 years, 6 months ago (2017-05-31 23:28:28 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 23:43:12 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6db567c03673972649d58ab0c088...

Powered by Google App Engine
This is Rietveld 408576698