Serialize also canonical names of 'interfaceTargetReference'.

pkg/kernel/lib/ast.dart

Index: pkg/kernel/lib/ast.dart
diff --git a/pkg/kernel/lib/ast.dart b/pkg/kernel/lib/ast.dart
index bcfae72741e3639c107f73b1187437b65eb1abcd..085394fe66aff35ea35d055082c9a347c1b7b100 100644
--- a/pkg/kernel/lib/ast.dart
+++ b/pkg/kernel/lib/ast.dart
@@ -1694,6 +1694,7 @@ class PropertyGet extends Expression {
   visitChildren(Visitor v) {
     receiver?.accept(v);
     name?.accept(v);
+    v.visitInterfaceTargetReference(interfaceTargetReference);

[Kevin Millikin (Google), 2017/05/30 15:11:33]

We don't usually structure visitors based on the semantics (purpose) of a
subpart, but rather the syntax (type) of it.  For instance, we wouldn't have
visitLoopCondition and visitLoopBody, but visitExpression and visitStatement.

I suggest to eliminate visitInterfaceTargetReference for this change and call
instead:

interfaceTargetReference?.acceptReference(v);

here and below.

[scheglov, 2017/05/30 17:45:50]

Hm... There is no method acceptReference in Reference.

So, I will go with Peter's suggestion and update ReferencesStringIndexer to
process nodes that have interfaceTargetReference instead of changing AST and
visitors.

   }
 
   transformChildren(Transformer v) {
@@ -1741,6 +1742,7 @@ class PropertySet extends Expression {
   visitChildren(Visitor v) {
     receiver?.accept(v);
     name?.accept(v);
+    v.visitInterfaceTargetReference(interfaceTargetReference);
     value?.accept(v);
   }
 
@@ -1940,6 +1942,7 @@ class SuperPropertyGet extends Expression {
 
   visitChildren(Visitor v) {
     name?.accept(v);
+    v.visitInterfaceTargetReference(interfaceTargetReference);
   }
 
   transformChildren(Transformer v) {}
@@ -1976,6 +1979,7 @@ class SuperPropertySet extends Expression {
 
   visitChildren(Visitor v) {
     name?.accept(v);
+    v.visitInterfaceTargetReference(interfaceTargetReference);
     value?.accept(v);
   }
 
@@ -2188,6 +2192,7 @@ class MethodInvocation extends InvocationExpression {
   visitChildren(Visitor v) {
     receiver?.accept(v);
     name?.accept(v);
+    v.visitInterfaceTargetReference(interfaceTargetReference);
     arguments?.accept(v);
   }
 
@@ -2245,6 +2250,7 @@ class SuperMethodInvocation extends InvocationExpression {
 
   visitChildren(Visitor v) {
     name?.accept(v);
+    v.visitInterfaceTargetReference(interfaceTargetReference);
     arguments?.accept(v);
   }