Serialize also canonical names of 'interfaceTargetReference'.

pkg/kernel/lib/ast.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// -----------------------------------------------------------------------
 ///                           ERROR HANDLING
 /// -----------------------------------------------------------------------
 ///
 /// As a rule of thumb, errors that can be detected statically are handled by
 /// the frontend, typically by translating the erroneous code into a 'throw' or
@@ skipping 1676 matching lines @@
     }
     return const DynamicType();
   }
 
   accept(ExpressionVisitor v) => v.visitPropertyGet(this);
   accept1(ExpressionVisitor1 v, arg) => v.visitPropertyGet(this, arg);
 
   visitChildren(Visitor v) {
     receiver?.accept(v);
     name?.accept(v);
+    v.visitInterfaceTargetReference(interfaceTargetReference);

[Kevin Millikin (Google), 2017/05/30 15:11:33]

We don't usually structure visitors based on the semantics (purpose) of a
subpart, but rather the syntax (type) of it.  For instance, we wouldn't have
visitLoopCondition and visitLoopBody, but visitExpression and visitStatement.

I suggest to eliminate visitInterfaceTargetReference for this change and call
instead:

interfaceTargetReference?.acceptReference(v);

here and below.

[scheglov, 2017/05/30 17:45:50]

Hm... There is no method acceptReference in Reference.

So, I will go with Peter's suggestion and update ReferencesStringIndexer to
process nodes that have interfaceTargetReference instead of changing AST and
visitors.

   }
 
   transformChildren(Transformer v) {
     if (receiver != null) {
       receiver = receiver.accept(v);
       receiver?.parent = this;
     }
   }
 }
 
@@ skipping 27 matching lines @@
   }
 
   DartType getStaticType(TypeEnvironment types) => value.getStaticType(types);
 
   accept(ExpressionVisitor v) => v.visitPropertySet(this);
   accept1(ExpressionVisitor1 v, arg) => v.visitPropertySet(this, arg);
 
   visitChildren(Visitor v) {
     receiver?.accept(v);
     name?.accept(v);
+    v.visitInterfaceTargetReference(interfaceTargetReference);
     value?.accept(v);
   }
 
   transformChildren(Transformer v) {
     if (receiver != null) {
       receiver = receiver.accept(v);
       receiver?.parent = this;
     }
     if (value != null) {
       value = value.accept(v);
@@ skipping 179 matching lines @@
     return Substitution
         .fromInterfaceType(receiver)
         .substituteType(interfaceTarget.getterType);
   }
 
   accept(ExpressionVisitor v) => v.visitSuperPropertyGet(this);
   accept1(ExpressionVisitor1 v, arg) => v.visitSuperPropertyGet(this, arg);
 
   visitChildren(Visitor v) {
     name?.accept(v);
+    v.visitInterfaceTargetReference(interfaceTargetReference);
   }
 
   transformChildren(Transformer v) {}
 }
 
 /// Expression of form `super.field = value`.
 ///
 /// This may invoke a setter or assign a field.
 ///
 /// Evaluates to the value of [value].
@@ skipping 16 matching lines @@
     interfaceTargetReference = getMemberReference(member);
   }
 
   DartType getStaticType(TypeEnvironment types) => value.getStaticType(types);
 
   accept(ExpressionVisitor v) => v.visitSuperPropertySet(this);
   accept1(ExpressionVisitor1 v, arg) => v.visitSuperPropertySet(this, arg);
 
   visitChildren(Visitor v) {
     name?.accept(v);
+    v.visitInterfaceTargetReference(interfaceTargetReference);
     value?.accept(v);
   }
 
   transformChildren(Transformer v) {
     if (value != null) {
       value = value.accept(v);
       value?.parent = this;
     }
   }
 }
@@ skipping 192 matching lines @@
     }
     return const DynamicType();
   }
 
   accept(ExpressionVisitor v) => v.visitMethodInvocation(this);
   accept1(ExpressionVisitor1 v, arg) => v.visitMethodInvocation(this, arg);
 
   visitChildren(Visitor v) {
     receiver?.accept(v);
     name?.accept(v);
+    v.visitInterfaceTargetReference(interfaceTargetReference);
     arguments?.accept(v);
   }
 
   transformChildren(Transformer v) {
     if (receiver != null) {
       receiver = receiver.accept(v);
       receiver?.parent = this;
     }
     if (arguments != null) {
       arguments = arguments.accept(v);
@@ skipping 37 matching lines @@
     return Substitution
         .fromPairs(interfaceTarget.function.typeParameters, arguments.types)
         .substituteType(returnType);
   }
 
   accept(ExpressionVisitor v) => v.visitSuperMethodInvocation(this);
   accept1(ExpressionVisitor1 v, arg) => v.visitSuperMethodInvocation(this, arg);
 
   visitChildren(Visitor v) {
     name?.accept(v);
+    v.visitInterfaceTargetReference(interfaceTargetReference);
     arguments?.accept(v);
   }
 
   transformChildren(Transformer v) {
     if (arguments != null) {
       arguments = arguments.accept(v);
       arguments?.parent = this;
     }
   }
 }
@@ skipping 2346 matching lines @@
 /// typedef has not been assigned a canonical name yet.
 ///
 /// Returns `null` if the typedef is `null`.
 CanonicalName getCanonicalNameOfTypedef(Typedef typedef_) {
   if (typedef_ == null) return null;
   if (typedef_.canonicalName == null) {
     throw '$typedef_ has no canonical name';
   }
   return typedef_.canonicalName;
 }