Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1195)

Issue 2906633002: Move ContextMenuAllowedScope to core/input (Closed)

Created:
3 years, 7 months ago by amaralp
Modified:
3 years, 7 months ago
CC:
blink-reviews, chromium-reviews, dcheng, dtapuska+blinkwatch_chromium.org, kinuko+watch, mlamouri+watch-blink_chromium.org, Navid Zolghadr
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ContextMenuAllowedScope to core/input Moving ContextMenuAllowedScope to core/input so it can be accessed from core in crrev.com/2785853002 BUG=627234 Review-Url: https://codereview.chromium.org/2906633002 Cr-Commit-Position: refs/heads/master@{#474626} Committed: https://chromium.googlesource.com/chromium/src/+/6f000e6717ad9f047c6e797b1ee7197e7c67e67f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -54 lines) Patch
M third_party/WebKit/Source/core/input/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/input/ContextMenuAllowedScope.h View 1 chunk +2 lines, -1 line 0 comments Download
A + third_party/WebKit/Source/core/input/ContextMenuAllowedScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/web/ContextMenuAllowedScope.h View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/Source/web/ContextMenuAllowedScope.cpp View 1 chunk +0 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/web/ContextMenuClientImpl.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
amaralp1
aelias@: Source/web bokan@: Source/core/input
3 years, 7 months ago (2017-05-25 07:14:16 UTC) #4
bokan
lgtm
3 years, 7 months ago (2017-05-25 11:23:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2906633002/1
3 years, 7 months ago (2017-05-25 11:23:42 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 11:28:25 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6f000e6717ad9f047c6e797b1ee7...

Powered by Google App Engine
This is Rietveld 408576698