Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1167)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2906603004: DevTools: update dropdowns to new style (Closed)

Created:
3 years, 7 months ago by luoe
Modified:
3 years, 6 months ago
Reviewers:
einbinder, dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: update dropdowns to new style BUG=690239 Review-Url: https://codereview.chromium.org/2906603004 Cr-Commit-Position: refs/heads/master@{#477160} Committed: https://chromium.googlesource.com/chromium/src/+/1192df1565e6591124601a249336a0879d0f4d09

Patch Set 1 #

Total comments: 2

Patch Set 2 : reduce brightness by 2 percent luminosity #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -27 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css View 1 1 chunk +15 lines, -27 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
luoe
To make things easier to review, this CL was split out, and only affects <select> ...
3 years, 7 months ago (2017-05-26 23:41:03 UTC) #2
pfeldman
lgtm https://codereview.chromium.org/2906603004/diff/1/third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css File third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css (right): https://codereview.chromium.org/2906603004/diff/1/third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css#newcode227 third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css:227: background-color: #fff; #fff seems to be to bright, ...
3 years, 6 months ago (2017-05-31 21:52:38 UTC) #3
luoe
All done! https://codereview.chromium.org/2906603004/diff/1/third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css File third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css (right): https://codereview.chromium.org/2906603004/diff/1/third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css#newcode227 third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css:227: background-color: #fff; On 2017/05/31 21:52:38, pfeldman wrote: ...
3 years, 6 months ago (2017-05-31 22:57:54 UTC) #4
pfeldman
lgtm
3 years, 6 months ago (2017-06-01 21:09:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2906603004/20001
3 years, 6 months ago (2017-06-05 23:01:07 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 02:43:34 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1192df1565e6591124601a249336...

Powered by Google App Engine
This is Rietveld 408576698