Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 2906583002: [WebView] native/ browser/ merge cleanup (Closed)

Created:
3 years, 7 months ago by Shimi Zhang
Modified:
3 years, 7 months ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org, Torne, Tobias Sargeant, sgurun-gerrit only
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebView] native/ browser/ merge cleanup This CL: 1) Removed uncessary create function in AwHttpAuthHandler 2) Merged test files into sources list. BUG=716604 Review-Url: https://codereview.chromium.org/2906583002 Cr-Commit-Position: refs/heads/master@{#474574} Committed: https://chromium.googlesource.com/chromium/src/+/754516566daa93b2e2362b24465c5af7aae30e5e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -24 lines) Patch
M android_webview/browser/aw_http_auth_handler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M android_webview/browser/aw_http_auth_handler.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M android_webview/browser/aw_login_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/test/BUILD.gn View 1 chunk +7 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Shimi Zhang
Bo, PTAL, thanks! After this CL, I think the merging is pretty much done, in ...
3 years, 7 months ago (2017-05-25 00:40:40 UTC) #4
boliu
lgtm
3 years, 7 months ago (2017-05-25 00:58:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2906583002/1
3 years, 7 months ago (2017-05-25 04:31:02 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 05:52:04 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/754516566daa93b2e2362b24465c...

Powered by Google App Engine
This is Rietveld 408576698