Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 290653004: Remove SkRecorder's kWriteOnly mode. (Closed)

Created:
6 years, 7 months ago by mtklein_C
Modified:
6 years, 6 months ago
Reviewers:
f(malita), mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Remove SkRecorder's kWriteOnly mode. I'm soon going to have SkRecorder start calling getTotalMatrix(), which would be broken in write-only mode. That change is big and nebulous, but it's clear kWriteOnly needs to go, so we might as well kill it now. My notes in bench_playback about kWriteOnly mode being important were probably overly cautious. I now think this is a fair enough comparison even re-recording into a read-write canvas. BUG=skia:2378 Committed: http://code.google.com/p/skia/source/detail?r=14963

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -69 lines) Patch
M dm/DMRecordTask.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/record/SkRecorder.h View 2 chunks +1 line, -11 lines 0 comments Download
M src/record/SkRecorder.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/record/SkRecording.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/RecordDrawTest.cpp View 1 3 chunks +5 lines, -5 lines 0 comments Download
M tests/RecordOptsTest.cpp View 1 8 chunks +8 lines, -8 lines 0 comments Download
M tests/RecordPatternTest.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M tests/RecorderTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/bench_playback.cpp View 4 chunks +25 lines, -27 lines 0 comments Download
M tools/dump_record.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mtklein
6 years, 7 months ago (2014-05-16 16:13:40 UTC) #1
mtklein
lgtm
6 years, 6 months ago (2014-05-29 16:00:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/290653004/20001
6 years, 6 months ago (2014-05-29 16:00:53 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-05-29 16:52:46 UTC) #4
Message was sent while issue was closed.
Change committed as 14963

Powered by Google App Engine
This is Rietveld 408576698