Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Unified Diff: src/record/SkRecorder.h

Issue 290653004: Remove SkRecorder's kWriteOnly mode. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dm/DMRecordTask.cpp ('k') | src/record/SkRecorder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/record/SkRecorder.h
diff --git a/src/record/SkRecorder.h b/src/record/SkRecorder.h
index e6bddd755c9c4d6d48f8e9c37983a9aec4361693..cee25c152bcf9692b9ff8ae395b2300509920a20 100644
--- a/src/record/SkRecorder.h
+++ b/src/record/SkRecorder.h
@@ -16,17 +16,8 @@
class SkRecorder : public SkCanvas {
public:
- // SkRecorder can work in two modes:
- // write-only: only a core subset of SkCanvas operations (save/restore, clip, transform, draw)
- // are supported, and all of the readback methods on SkCanvas will probably fail or lie.
- //
- // read-write: all methods should behave with similar semantics to SkCanvas.
- //
- // Write-only averages 10-20% faster, but you can't sensibly inspect the canvas while recording.
- enum Mode { kWriteOnly_Mode, kReadWrite_Mode };
-
// Does not take ownership of the SkRecord.
- SkRecorder(Mode mode, SkRecord*, int width, int height);
+ SkRecorder(SkRecord*, int width, int height);
// Make SkRecorder forget entirely about its SkRecord*; all calls to SkRecorder will fail.
void forgetRecord();
@@ -114,7 +105,6 @@ private:
template <typename T>
T* copy(const T[], unsigned count);
- const Mode fMode;
SkRecord* fRecord;
};
« no previous file with comments | « dm/DMRecordTask.cpp ('k') | src/record/SkRecorder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698