Chrome Cleaner UI: Use BrowserThread's DeleteOnIOThread for ChromePromptImpl

Chrome Cleaner UI: Use BrowserThread's DeleteOnIOThread for ChromePromptImpl

This replaces the current approach of explicitly posting the deletion
of the ChromePromptImpl with using BrowserThread::DeleteOnIOThread.

BUG=

Review-Url: https://codereview.chromium.org/2906493004
Cr-Commit-Position: refs/heads/master@{#474825}
Committed: https://chromium.googlesource.com/chromium/src/+/23a05226c797eef166f706742ac069cd436814f6

[alito, 2017-05-25 20:03:18]

alito@chromium.org changed reviewers:
+ csharp@chromium.org, joenotcharles@google.com

[alito, 2017-05-25 20:03:19]

PTAL!

[csharp, 2017-05-25 20:39:19]

lgtm

https://codereview.chromium.org/2906493004/diff/20001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_runner_win.cc
(right):

https://codereview.chromium.org/2906493004/diff/20001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_runner_win.cc:187:
ChromeCleanerRunner::~ChromeCleanerRunner() = default;
nit: Since this is just default now, you can just do it in the header.

[Joe Mason, 2017-05-25 20:41:13]

joenotcharles@chromium.org changed reviewers:
+ joenotcharles@chromium.org

[Joe Mason, 2017-05-25 20:41:13]

lgtm

https://codereview.chromium.org/2906493004/diff/20001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_runner_win.cc
(right):

https://codereview.chromium.org/2906493004/diff/20001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_runner_win.cc:194:
chrome_prompt_impl_.reset(new ChromePromptImpl(
Nit: perhaps a comment explaining why you can't use MakeUnique here, since
people have mentioned giving bare new extra scrutiny.

[alito, 2017-05-25 20:46:55]

Patchset #3 (id:40001) has been deleted

[alito, 2017-05-25 20:48:47]

The CQ bit was checked by alito@chromium.org

[alito, 2017-05-25 20:48:47]

The patchset sent to the CQ was uploaded after l-g-t-m from csharp@chromium.org,
joenotcharles@chromium.org
Link to the patchset: https://codereview.chromium.org/2906493004/#ps60001
(title: "Add comment explaining the use of bare new.")

[commit-bot: I haz the power, 2017-05-25 20:49:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 22:34:25]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495745327232370,
"parent_rev": "16ca9f743af85a9194b63b4585636d59b7c6bf53", "commit_rev":
"a8bc087a849792b0cc533a1b77717551926413f6"}

[commit-bot: I haz the power, 2017-05-25 22:34:56]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495745327232370,
"parent_rev": "a363e3bdb058af7d9da96c5a7d27c192632e2ada", "commit_rev":
"23a05226c797eef166f706742ac069cd436814f6"}

[commit-bot: I haz the power, 2017-05-25 22:35:11]

Description was changed from

==========
Chrome Cleaner UI: Use BrowserThread's DeleteOnIOThread for ChromePromptImpl

This replaces the current approach of explicitly posting the deletion
of the ChromePromptImpl with using BrowserThread::DeleteOnIOThread.

BUG=
==========

to

==========
Chrome Cleaner UI: Use BrowserThread's DeleteOnIOThread for ChromePromptImpl

This replaces the current approach of explicitly posting the deletion
of the ChromePromptImpl with using BrowserThread::DeleteOnIOThread.

BUG=

Review-Url: https://codereview.chromium.org/2906493004
Cr-Commit-Position: refs/heads/master@{#474825}
Committed:
https://chromium.googlesource.com/chromium/src/+/23a05226c797eef166f706742ac0...
==========

[commit-bot: I haz the power, 2017-05-25 22:35:17]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/23a05226c797eef166f706742ac0...

[alito, 2017-05-26 15:29:39]

Forgot to send out these replies to final comments. Here they are now.

https://codereview.chromium.org/2906493004/diff/20001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_runner_win.cc
(right):

https://codereview.chromium.org/2906493004/diff/20001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_runner_win.cc:187:
ChromeCleanerRunner::~ChromeCleanerRunner() = default;
On 2017/05/25 20:39:19, csharp wrote:
> nit: Since this is just default now, you can just do it in the header.

As discussed, this should be here according to Chromium's C++ Dos and Don'ts
doc.

https://codereview.chromium.org/2906493004/diff/20001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_runner_win.cc:194:
chrome_prompt_impl_.reset(new ChromePromptImpl(
On 2017/05/25 20:41:13, Joe Mason wrote:
> Nit: perhaps a comment explaining why you can't use MakeUnique here, since
> people have mentioned giving bare new extra scrutiny.

Done.