Teach PasswordAutofillAgent sometimes match prefixes of usernames

chrome/renderer/autofill/password_autofill_agent_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/password_autofill_agent.h"
 
 #include "base/macros.h"
 #include "base/run_loop.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
@@ skipping 699 matching lines @@
        AutocompletePasswordForReadonlyUsernameMatched) {
   username_element_.SetValue(WebString::FromUTF16(username3_));
   SetElementReadOnly(username_element_, true);
 
   // Filled even though username is not the preferred match.
   SimulateOnFillPasswordForm(fill_data_);
   CheckTextFieldsState(UTF16ToUTF8(username3_), false,
                        UTF16ToUTF8(password3_), true);
 }
 
+// Fill a password field if the stored username is a prefix of username in
+// read-only field.
+TEST_F(PasswordAutofillAgentTest,
+       AutocompletePasswordForReadonlyUsernamePrefixMatched) {

[vabr (Chromium), 2017/06/12 18:56:58]

Could you please also add a negative test? For example for username vs username
+ "suffix_without_@".
The goal is not to test all options (that's done by the unittest), but to test
that the negative path is executed at all.

Furthermore, could you please also add a test that if there is no username
field, and the saved credentials contain an empty username, then the password is
filled properly? The part of code which you are changing handles this event as
well (despite it is not related to prefix matching), and AFAICT, we don't have a
test for that yet.

[melandory, 2017/06/19 10:53:48]

Done
https://codereview.chromium.org/2949533002

+  base::string16 username_at = username3_ + base::UTF8ToUTF16("@example.com");
+  username_element_.SetValue(WebString::FromUTF16(username3_));
+  SetElementReadOnly(username_element_, true);
+
+  // Filled even though username is not the preferred match.

[vabr (Chromium), 2017/06/12 18:56:58]

nit: "preferred match" is a sort of a term, used in PasswordFormManager to
denote the last used credentials on a form. Here it seems more precise to say:
"...though the username in the form is only a proper prefix of the stored
username"

[melandory, 2017/06/19 10:53:48]

Done.

+  SimulateOnFillPasswordForm(fill_data_);
+  CheckTextFieldsState(UTF16ToUTF8(username3_), false, UTF16ToUTF8(password3_),
+                       true);
+}
 // If a username field is empty and readonly, don't autofill.
 TEST_F(PasswordAutofillAgentTest,
        NoAutocompletePasswordForReadonlyUsernameUnmatched) {
   username_element_.SetValue(WebString::FromUTF8(""));
   SetElementReadOnly(username_element_, true);
 
   SimulateOnFillPasswordForm(fill_data_);
   CheckTextFieldsState(std::string(), false, std::string(), false);
 }
 
@@ skipping 2224 matching lines @@
 TEST_F(PasswordAutofillAgentTest, AutocompleteWhenPageUrlIsChanged) {
   // Simulate that JavaScript changes url.
   fill_data_.origin = GURL(fill_data_.origin.possibly_invalid_spec() + "/path");
 
   SimulateOnFillPasswordForm(fill_data_);
 
   // The username and password should have been autocompleted.
   CheckTextFieldsState(kAliceUsername, true, kAlicePassword, true);
 }
 }  // namespace autofill