Test for the autofill login for the form without username field.

Test for the autofill login for the form without username field.

This CL adds the test case to the autofill agent browser tests. The test case
checks the autofill logic on the form without username. It's expected that if
the user has saved credential with the empty username, then the password is
filled to the form without username.

BUG=543435

[melandory, 2017-06-19 10:53:08]

The CQ bit was checked by melandory@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-19 10:53:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 11:01:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-19 11:01:16]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[vabr (Chromium), 2017-06-19 13:03:35]

vabr@chromium.org changed reviewers:
+ vabr@chromium.org

[vabr (Chromium), 2017-06-19 13:03:36]

The spirit LGTM, let's fix the details.

(Apologies for unsolicited review, I followed the link from the other CL and
only now noticed that you did not send out this one yet. If the comment below
does not make sense, then please just ignore it. :))

Cheers,
Vaclav

https://codereview.chromium.org/2949533002/diff/1/chrome/renderer/autofill/pa...
File chrome/renderer/autofill/password_autofill_agent_browsertest.cc (right):

https://codereview.chromium.org/2949533002/diff/1/chrome/renderer/autofill/pa...
chrome/renderer/autofill/password_autofill_agent_browsertest.cc:738:
SimulateOnFillPasswordForm(fill_data_);
Instead of fill_data_, you might need to make a copy and clear its
username_field. Also, password_for_empty_username_ does not seem defined, so
probably just use the password_field.value from the modified FillData.

[melandory, 2017-06-20 13:04:56]

On 2017/06/19 13:03:36, vabr (Chromium) wrote:
> The spirit LGTM, let's fix the details.
> 
> (Apologies for unsolicited review, I followed the link from the other CL and
> only now noticed that you did not send out this one yet. If the comment below
> does not make sense, then please just ignore it. :))
Yeah, it was just FIY ;)  I can't make the test work for now, I'll let you know
once it's ready.
> 
> Cheers,
> Vaclav
> 
>
https://codereview.chromium.org/2949533002/diff/1/chrome/renderer/autofill/pa...
> File chrome/renderer/autofill/password_autofill_agent_browsertest.cc (right):
> 
>
https://codereview.chromium.org/2949533002/diff/1/chrome/renderer/autofill/pa...
> chrome/renderer/autofill/password_autofill_agent_browsertest.cc:738:
> SimulateOnFillPasswordForm(fill_data_);
> Instead of fill_data_, you might need to make a copy and clear its
> username_field. Also, password_for_empty_username_ does not seem defined, so
> probably just use the password_field.value from the modified FillData.