Issue 290633006: Revert 270907 "Remove knowledge of nacl from content."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 290633006: Revert 270907 "Remove knowledge of nacl from content." (Closed)

Created:
6 years, 7 months ago by benwells

Modified:
6 years, 7 months ago

Reviewers:
bradn

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 270907 "Remove knowledge of nacl from content." > Remove knowledge of nacl from content. > > Content should not have knowledge of NaCl. Moving per process NaCl debug > stub port information to NaClBrowser. > > More explicitly distiquish between the case where the debug port is not yet > known versus when it is unused. > > Switch debug port to being a per-process value (as it is). > > BUG=None > TEST=trybots > R=jam@chromium.org > > Review URL: https://codereview.chromium.org/286993006 This caused the compile to fail on the TSAN v2 bot: http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Builder%20%28TSan%20v2%29/builds/19971 TBR=bradnelson@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270924

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -70 lines)			Patch
M	trunk/src/chrome/browser/task_manager/child_process_resource_provider.cc	View	5 chunks	+13 lines, -3 lines	0 comments	Download
M	trunk/src/chrome/browser/task_manager/resource_provider.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/task_manager/resource_provider.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/task_manager/task_manager.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	trunk/src/chrome/browser/task_manager/task_manager.cc	View	7 chunks	+9 lines, -23 lines	0 comments	Download
M	trunk/src/components/nacl/browser/nacl_browser.h	View	4 chunks	+2 lines, -12 lines	0 comments	Download
M	trunk/src/components/nacl/browser/nacl_browser.cc	View	3 chunks	+9 lines, -21 lines	0 comments	Download
M	trunk/src/components/nacl/browser/nacl_process_host.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	trunk/src/components/nacl/browser/nacl_process_host.cc	View	4 chunks	+6 lines, -5 lines	0 comments	Download
M	trunk/src/content/browser/browser_child_process_host_impl.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	trunk/src/content/browser/browser_child_process_host_impl.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	trunk/src/content/public/browser/browser_child_process_host.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	trunk/src/content/public/browser/child_process_data.h	View	1 chunk	+4 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r270924.