Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Unified Diff: trunk/src/components/nacl/browser/nacl_browser.h

Issue 290633006: Revert 270907 "Remove knowledge of nacl from content." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/components/nacl/browser/nacl_browser.h
===================================================================
--- trunk/src/components/nacl/browser/nacl_browser.h (revision 270923)
+++ trunk/src/components/nacl/browser/nacl_browser.h (working copy)
@@ -25,9 +25,6 @@
namespace nacl {
-static const int kGdbDebugStubPortUnknown = -1;
-static const int kGdbDebugStubPortUnused = 0;
-
// Open an immutable executable file that can be mmapped.
// This function should only be called on a thread that can perform file IO.
base::File OpenNaClExecutableImpl(const base::FilePath& file_path);
@@ -68,12 +65,11 @@
// debug stub server instead of a fixed one.
// Notify listener that new debug stub TCP port is allocated.
- void SetProcessGdbDebugStubPort(int process_id, int port);
+ void FireGdbDebugStubPortOpened(int port);
+ bool HasGdbDebugStubPortListener();
void SetGdbDebugStubPortListener(base::Callback<void(int)> listener);
void ClearGdbDebugStubPortListener();
- int GetProcessGdbDebugStubPort(int process_id);
-
bool ValidationCacheIsEnabled() const {
return validation_cache_is_enabled_;
}
@@ -121,8 +117,6 @@
static void SetDelegate(NaClBrowserDelegate* delegate);
static NaClBrowserDelegate* GetDelegate();
- // Each time a NaCl process ends, the browser is notified.
- void OnProcessEnd(int process_id);
// Support for NaCl crash throttling.
// Each time a NaCl module crashes, the browser is notified.
void OnProcessCrashed();
@@ -177,10 +171,6 @@
NaClResourceState validation_cache_state_;
base::Callback<void(int)> debug_stub_port_listener_;
- // Map from process id to debug stub port if any.
- typedef std::map<int, int> GdbDebugStubPortMap;
- GdbDebugStubPortMap gdb_debug_stub_port_map_;
-
typedef base::HashingMRUCache<std::string, base::FilePath> PathCacheType;
PathCacheType path_cache_;
« no previous file with comments | « trunk/src/chrome/browser/task_manager/task_manager.cc ('k') | trunk/src/components/nacl/browser/nacl_browser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698