content/browser/renderer_host/render_view_host_impl.h - Issue 290633002: Implement Android accessible hit testing using an IPC to the renderer process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_impl.h

Issue 290633002: Implement Android accessible hit testing using an IPC to the renderer process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@better_logging_2

Patch Set: Tweak to algorithm to find highest leaf ancestor Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_manager_android.cc ('k') | content/browser/renderer_host/render_view_host_impl.cc » ('j') | content/browser/renderer_host/render_widget_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_view_host_impl.h

diff --git a/content/browser/renderer_host/render_view_host_impl.h b/content/browser/renderer_host/render_view_host_impl.h

index 4e3d5ced4225495b3ff22b7064a1eddb2f792c57..a4e6850de5ddec11f71923e2b12e58b9a3846b57 100644

--- a/content/browser/renderer_host/render_view_host_impl.h

+++ b/content/browser/renderer_host/render_view_host_impl.h

@@ -408,7 +408,7 @@ class CONTENT_EXPORT RenderViewHostImpl

// renderer process, and the accessibility tree it sent can be

// retrieved using accessibility_tree_for_testing().

void SetAccessibilityCallbackForTesting(

- const base::Callback<void(ui::AXEvent)>& callback);

+ const base::Callback<void(ui::AXEvent, int)>& callback);

// Only valid if SetAccessibilityCallbackForTesting was called and

// the callback was run at least once. Returns a snapshot of the

@@ -607,7 +607,7 @@ class CONTENT_EXPORT RenderViewHostImpl

bool unload_ack_is_for_cross_site_transition_;

// Accessibility callback for testing.

- base::Callback<void(ui::AXEvent)> accessibility_testing_callback_;

+ base::Callback<void(ui::AXEvent, int)> accessibility_testing_callback_;

// The most recently received accessibility tree - for testing only.

scoped_ptr<ui::AXTree> ax_tree_;