content/browser/renderer_host/render_view_host_impl.cc - Issue 290633002: Implement Android accessible hit testing using an IPC to the renderer process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 290633002: Implement Android accessible hit testing using an IPC to the renderer process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@better_logging_2

Patch Set: Tweak to algorithm to find highest leaf ancestor Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.h ('k') | content/browser/renderer_host/render_widget_host_impl.h » ('j') | content/browser/renderer_host/render_widget_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_view_host_impl.cc

diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc

index 562e611ef20b32b34f9be51c52c46bbbe411d5ac..480efebf5285db6c83f8fd7e3f69335e7e6c8c6c 100644

--- a/content/browser/renderer_host/render_view_host_impl.cc

+++ b/content/browser/renderer_host/render_view_host_impl.cc

@@ -1478,7 +1478,7 @@ void RenderViewHostImpl::DisownOpener() {

}

void RenderViewHostImpl::SetAccessibilityCallbackForTesting(

- const base::Callback<void(ui::AXEvent)>& callback) {

+ const base::Callback<void(ui::AXEvent, int)>& callback) {

accessibility_testing_callback_ = callback;

}

@@ -1589,7 +1589,7 @@ void RenderViewHostImpl::OnAccessibilityEvents(

ax_tree_.reset(new ui::AXTree(param.update));

else

CHECK(ax_tree_->Unserialize(param.update)) << ax_tree_->error();

- accessibility_testing_callback_.Run(param.event_type);

+ accessibility_testing_callback_.Run(param.event_type, param.id);

}