Rename ArcCustomNotificationView to ArcNotificationContentView

Rename ArcCustomNotificationView to ArcNotificationContentView

This CL is just a refactoring so doesn't change any behavior.

BUG=697359
TEST=none

Review-Url: https://codereview.chromium.org/2906323002
Cr-Commit-Position: refs/heads/master@{#475855}
Committed: https://chromium.googlesource.com/chromium/src/+/e4c379cd8ceb33e1168fb071a2f27c0d74562e11

[yoshiki, 2017-05-29 10:39:47]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-29 10:39:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 12:07:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 12:07:40]

Dry run: This issue passed the CQ dry run.

[yoshiki, 2017-05-30 03:14:19]

Description was changed from

==========
wip

BUG=
==========

to

==========
Rename ArcCustomNotificationView to ArcNotificationContentView

This CL is just a refactoring so doesn't change any behavior.

BUG=697359
TEST=none
==========

[yoshiki, 2017-05-30 03:14:19]

yoshiki@chromium.org changed reviewers:
+ edcourtney@chromium.org, hidehiko@chromium.org, yhanada@chromium.org

[yoshiki, 2017-05-30 03:14:19]

yoshiki@chromium.org changed required reviewers:
+ hidehiko@chromium.org

[yoshiki, 2017-05-30 03:14:43]

Hidehiko-san, PTAL. (Hanada-san, Eliot, JFYI)

[hidehiko, 2017-05-31 03:48:38]

LGTM with minor comments.
Sorry for delay.

https://codereview.chromium.org/2906323002/diff/1/ui/arc/notification/arc_not...
File ui/arc/notification/arc_notification_content_view.h (right):

https://codereview.chromium.org/2906323002/diff/1/ui/arc/notification/arc_not...
ui/arc/notification/arc_notification_content_view.h:42: // TODO(yoshiki): Rename
this class to ArcNotificationContentsView.
nit: please remove TODO.

https://codereview.chromium.org/2906323002/diff/1/ui/arc/notification/arc_not...
File ui/arc/notification/arc_notification_view.cc (right):

https://codereview.chromium.org/2906323002/diff/1/ui/arc/notification/arc_not...
ui/arc/notification/arc_notification_view.cc:9: #include
"ui/arc/notification/arc_notification_content_view.h"
Unused. Could you remove?

[yoshiki, 2017-05-31 04:26:08]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 04:26:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 04:28:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 04:28:20]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[yoshiki, 2017-05-31 04:47:22]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 04:47:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 05:01:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 05:01:53]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[yoshiki, 2017-05-31 05:39:41]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 05:40:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 06:05:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 06:05:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yoshiki, 2017-05-31 06:13:26]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 06:13:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoshiki, 2017-05-31 06:20:06]

Patchset #3 (id:40001) has been deleted

[yoshiki, 2017-05-31 06:20:14]

Patchset #3 (id:60001) has been deleted

[commit-bot: I haz the power, 2017-05-31 07:35:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 07:35:54]

Dry run: This issue passed the CQ dry run.

[yoshiki, 2017-05-31 09:18:14]

Patchset #2 (id:20001) has been deleted

[yoshiki, 2017-05-31 09:18:29]

Thank you!

https://codereview.chromium.org/2906323002/diff/1/ui/arc/notification/arc_not...
File ui/arc/notification/arc_notification_content_view.h (right):

https://codereview.chromium.org/2906323002/diff/1/ui/arc/notification/arc_not...
ui/arc/notification/arc_notification_content_view.h:42: // TODO(yoshiki): Rename
this class to ArcNotificationContentsView.
On 2017/05/31 03:48:38, hidehiko wrote:
> nit: please remove TODO.

Good catch. Done.

https://codereview.chromium.org/2906323002/diff/1/ui/arc/notification/arc_not...
File ui/arc/notification/arc_notification_view.cc (right):

https://codereview.chromium.org/2906323002/diff/1/ui/arc/notification/arc_not...
ui/arc/notification/arc_notification_view.cc:9: #include
"ui/arc/notification/arc_notification_content_view.h"
On 2017/05/31 03:48:38, hidehiko wrote:
> Unused. Could you remove?

Done.

[yoshiki, 2017-05-31 09:18:34]

The CQ bit was checked by yoshiki@chromium.org

[yoshiki, 2017-05-31 09:18:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
hidehiko@chromium.org
Link to the patchset: https://codereview.chromium.org/2906323002/#ps80001
(title: "Addressed comments")

[commit-bot: I haz the power, 2017-05-31 09:18:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 09:22:20]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1496222314292250,
"parent_rev": "03d9ba3df2b5e46e27b9d2c214d82aaba2d53510", "commit_rev":
"e4c379cd8ceb33e1168fb071a2f27c0d74562e11"}

[commit-bot: I haz the power, 2017-05-31 09:22:32]

Description was changed from

==========
Rename ArcCustomNotificationView to ArcNotificationContentView

This CL is just a refactoring so doesn't change any behavior.

BUG=697359
TEST=none
==========

to

==========
Rename ArcCustomNotificationView to ArcNotificationContentView

This CL is just a refactoring so doesn't change any behavior.

BUG=697359
TEST=none

Review-Url: https://codereview.chromium.org/2906323002
Cr-Commit-Position: refs/heads/master@{#475855}
Committed:
https://chromium.googlesource.com/chromium/src/+/e4c379cd8ceb33e1168fb071a2f2...
==========

[commit-bot: I haz the power, 2017-05-31 09:22:34]

Committed patchset #2 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/e4c379cd8ceb33e1168fb071a2f2...