[ios clean] ToolsMenu Mediator observes Webstate.

ios/clean/chrome/browser/ui/tools/tools_mediator.h

Index: ios/clean/chrome/browser/ui/tools/tools_mediator.h
diff --git a/ios/clean/chrome/browser/ui/tools/tools_mediator.h b/ios/clean/chrome/browser/ui/tools/tools_mediator.h
index d13f54d914687f3b677f1b7a8a80d07c5a85993e..b73d4ec8c0c1e8df2841491215408a4d6ddf6039 100644
--- a/ios/clean/chrome/browser/ui/tools/tools_mediator.h
+++ b/ios/clean/chrome/browser/ui/tools/tools_mediator.h
@@ -9,14 +9,22 @@
 
 @protocol ToolsConsumer;
 @class ToolsMenuConfiguration;
+namespace web {
+class WebState;
+}
 
 // A mediator object that sets a ToolsMenuVC appeareance based on various data
 // sources.
 @interface ToolsMediator : NSObject
-- (instancetype)initWithConsumer:(id<ToolsConsumer>)consumer
-                andConfiguration:(ToolsMenuConfiguration*)menuConfiguration
+- (nullable instancetype)initWithConsumer:(nonnull id<ToolsConsumer>)consumer
+                         andConfiguration:

[marq (ping after 24h), 2017/05/30 09:24:54]

Naming nit: Don't use 'and' to connect keywords in method names. 'and' is only
used to indicate a second action the method performs
("-doSomethingWithThis:andDoSomethingElseWithThis:"). 

Generally keywords after the first in initializers shouldn't need prepositions
or conjunctions, so 'initWithConsumer:configuration:' should be sufficient.

[sczs, 2017/05/31 03:05:48]

Thanks for the tip! Done.

+                             (nonnull ToolsMenuConfiguration*)menuConfiguration
     NS_DESIGNATED_INITIALIZER;
-- (instancetype)init NS_UNAVAILABLE;
+- (nullable instancetype)init NS_UNAVAILABLE;
+
+// The WebState whose properties this object mediates. This can change during
+// the lifetime of this object and may be null.
+@property(nonatomic, assign, nullable) web::WebState* webState;

[sczs, 2017/05/31 03:05:47]

Thought it would be a good idea to start using Nullability annotations after the
WSL discussion. I know we still haven't decided if we are going to use them, or
which style to follow. So I can remove these if you have any objection or
concern. 

[marq (ping after 24h), 2017/05/31 10:40:31]

We have them in other places. As a matter of general ObjC style, it's under
heavy discussion; I myself don't have a clear idea about what I'd like to see.

[sczs, 2017/05/31 23:19:26]

Acknowledged.

 @end
 
 #endif  // IOS_CLEAN_CHROME_BROWSER_UI_TOOLS_TOOLS_MEDIATOR_H_