[ios clean] ToolsMenu Mediator observes Webstate.

ios/clean/chrome/browser/ui/tools/tools_coordinator.h

Index: ios/clean/chrome/browser/ui/tools/tools_coordinator.h
diff --git a/ios/clean/chrome/browser/ui/tools/tools_coordinator.h b/ios/clean/chrome/browser/ui/tools/tools_coordinator.h
index 457392d689dba3c7991145cbabd97275f986f5d8..1fd2f74797ce2f02aeefba6098c8059fac41e669 100644
--- a/ios/clean/chrome/browser/ui/tools/tools_coordinator.h
+++ b/ios/clean/chrome/browser/ui/tools/tools_coordinator.h
@@ -7,12 +7,19 @@
 
 #import "ios/shared/chrome/browser/ui/coordinators/browser_coordinator.h"
 
+namespace web {
+class WebState;

[marq (ping after 24h), 2017/05/30 09:24:54]

nit: alpha order for forward declarations, so web::WebState comes after
ToolsMenuConfiguration.

[sczs, 2017/05/31 03:05:47]

Done.

+}
 @class ToolsMenuConfiguration;
 
 // Coordinator that shows an inteface for the user to select a
 // tool or action to use.
 @interface ToolsCoordinator : BrowserCoordinator
-@property(nonatomic, strong) ToolsMenuConfiguration* toolsMenuConfiguration;
+// The current Toolbar configuration for this coordinator.
+@property(nonatomic, strong, nonnull)
+    ToolsMenuConfiguration* toolsMenuConfiguration;
+// The web state this ToolbarCoordinator is handling.
+@property(nonatomic, assign, nullable) web::WebState* webState;

[marq (ping after 24h), 2017/05/30 09:24:54]

Is 'nullable' meaningful for pointers to C++ objects?

[sczs, 2017/05/31 03:05:47]

Yes, it works with C++ objects. I think the most meaningful thing is the
documentation part of stating that this can be nullptr.

[marq (ping after 24h), 2017/05/31 10:40:31]

My current thinking on nullability annotations are that they were added by Apple
to make interoperating with Swift's monads, but they are starting to be used as
if they were enforced the way 'const' is in C++ (which they are not). I'm fine
with this as-is, but remember we can always just use comments as well.

[sczs, 2017/05/31 23:19:26]

Acknowledged.

 @end
 
 #endif  // IOS_CLEAN_CHROME_BROWSER_UI_TOOLS_TOOLS_COORDINATOR_H_