Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2906313002: [heap] Fix a missing write barrier in Heap::Allocate. (Closed)

Created:
3 years, 6 months ago by ulan
Modified:
3 years, 6 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office)
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Fix a missing write barrier in Heap::Allocate. BUG= Review-Url: https://codereview.chromium.org/2906313002 Cr-Commit-Position: refs/heads/master@{#45571} Committed: https://chromium.googlesource.com/v8/v8/+/b853d7fbb395b72829c5220126fd0cda43a65acf

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -2 lines) Patch
M src/heap/heap.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M test/cctest/heap/heap-tester.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
ulan
ptal
3 years, 6 months ago (2017-05-29 10:01:04 UTC) #2
Michael Lippautz
LGTM
3 years, 6 months ago (2017-05-29 11:27:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2906313002/1
3 years, 6 months ago (2017-05-29 11:29:08 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/26606) v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
3 years, 6 months ago (2017-05-29 12:28:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2906313002/20001
3 years, 6 months ago (2017-05-29 14:05:30 UTC) #10
commit-bot: I haz the power
CQ experienced an internal error when committing your CL and the maintainers were notified. Sorry ...
3 years, 6 months ago (2017-05-29 14:55:49 UTC) #12
tandrii_google
On 2017/05/29 14:55:49, commit-bot: I haz the power wrote: > CQ experienced an internal error ...
3 years, 6 months ago (2017-05-29 14:56:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2906313002/20001
3 years, 6 months ago (2017-05-29 14:56:37 UTC) #15
commit-bot: I haz the power
Internal error: failed to checkout. Please try again.
3 years, 6 months ago (2017-05-29 14:59:39 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2906313002/20001
3 years, 6 months ago (2017-05-29 15:02:36 UTC) #19
commit-bot: I haz the power
3 years, 6 months ago (2017-05-29 15:03:59 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/b853d7fbb395b72829c5220126fd0cda43a...

Powered by Google App Engine
This is Rietveld 408576698