Take into account options.offset in onReadFileRequested.

Take into account options.offset in onReadFileRequested.

fileSystemProvider example extension did not take into account
options.offset in onReadFileRequested, which resulted in generating a
file of infinite length when the file is copied.

BUG=727207
TBR=rdevlin.cronin@chromium.org

Review-Url: https://codereview.chromium.org/2906283002
Cr-Commit-Position: refs/heads/master@{#475305}
Committed: https://chromium.googlesource.com/chromium/src/+/d0ee74f331d96323941af0cee83a2c789ad847be

[tetsui, 2017-05-29 07:05:01]

tetsui@chromium.org changed reviewers:
+ mtomasz@chromium.org

[tetsui, 2017-05-29 07:05:02]

mtomasz@: Please take a look. Thank you.

[tetsui, 2017-05-29 07:05:17]

The CQ bit was checked by tetsui@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-29 07:05:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtomasz, 2017-05-29 07:10:17]

lgtm with optional nit

https://codereview.chromium.org/2906283002/diff/1/chrome/common/extensions/do...
File
chrome/common/extensions/docs/examples/api/fileSystemProvider/basic/background.js
(right):

https://codereview.chromium.org/2906283002/diff/1/chrome/common/extensions/do...
chrome/common/extensions/docs/examples/api/fileSystemProvider/basic/background.js:98:
}
I think we could simplify:

var remaining = Math.max(0, contents.length - options.offset);
var length = Math.min(remaining, options.length);

WDYT?

[commit-bot: I haz the power, 2017-05-29 07:15:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 07:15:25]

Dry run: This issue passed the CQ dry run.

[tetsui, 2017-05-29 07:22:37]

Thank you for quick response! BTW, who should I ask OWNERS review for? Because
this is under docs, TBR is appropriate?

https://codereview.chromium.org/2906283002/diff/1/chrome/common/extensions/do...
File
chrome/common/extensions/docs/examples/api/fileSystemProvider/basic/background.js
(right):

https://codereview.chromium.org/2906283002/diff/1/chrome/common/extensions/do...
chrome/common/extensions/docs/examples/api/fileSystemProvider/basic/background.js:98:
}
On 2017/05/29 07:10:17, mtomasz wrote:
> I think we could simplify:
> 
> var remaining = Math.max(0, contents.length - options.offset);
> var length = Math.min(remaining, options.length);
> 
> WDYT?

Done.

[mtomasz, 2017-05-29 07:26:42]

Hm, let's TBR rdevlin.cronin.

[tetsui, 2017-05-29 07:30:14]

Description was changed from

==========
Take into account options.offset in onReadFileRequested.

fileSystemProvider example extension did not take into account
options.offset in onReadFileRequested, which resulted in generating a
file of infinite length when the file is copied.

BUG=727207
==========

to

==========
Take into account options.offset in onReadFileRequested.

fileSystemProvider example extension did not take into account
options.offset in onReadFileRequested, which resulted in generating a
file of infinite length when the file is copied.

BUG=727207
TBR=rdevlin.cronin@chromium.org
==========

[tetsui, 2017-05-29 07:30:48]

On 2017/05/29 07:26:42, mtomasz wrote:
> Hm, let's TBR rdevlin.cronin.

Thanks!

[tetsui, 2017-05-29 07:30:52]

The CQ bit was checked by tetsui@chromium.org

[tetsui, 2017-05-29 07:30:53]

The patchset sent to the CQ was uploaded after l-g-t-m from mtomasz@chromium.org
Link to the patchset: https://codereview.chromium.org/2906283002/#ps20001
(title: "Fix nits.")

[commit-bot: I haz the power, 2017-05-29 07:31:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 07:42:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496043052980260,
"parent_rev": "f85c8f7ffc6cade8917ac5eb37b30c5baaf403f9", "commit_rev":
"d0ee74f331d96323941af0cee83a2c789ad847be"}

[commit-bot: I haz the power, 2017-05-29 07:42:17]

Description was changed from

==========
Take into account options.offset in onReadFileRequested.

fileSystemProvider example extension did not take into account
options.offset in onReadFileRequested, which resulted in generating a
file of infinite length when the file is copied.

BUG=727207
TBR=rdevlin.cronin@chromium.org
==========

to

==========
Take into account options.offset in onReadFileRequested.

fileSystemProvider example extension did not take into account
options.offset in onReadFileRequested, which resulted in generating a
file of infinite length when the file is copied.

BUG=727207
TBR=rdevlin.cronin@chromium.org

Review-Url: https://codereview.chromium.org/2906283002
Cr-Commit-Position: refs/heads/master@{#475305}
Committed:
https://chromium.googlesource.com/chromium/src/+/d0ee74f331d96323941af0cee83a...
==========

[commit-bot: I haz the power, 2017-05-29 07:42:19]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d0ee74f331d96323941af0cee83a...