Change SelectionModifier::ModifyMovingRight() not to use redundant local variable

Change SelectionModifier::ModifyMovingRight() not to use redundant local variable

This patch replaces redundant local variable |pop| with |return| statement in
|SelectionModifier::ModifyMovingRight()| to simplify and switches then-clause
and else-clause to reduce indentation for improving code health.

This patch also adds |NOTREACHED()| to catch unexpected cases.

This patch is a preparation of adopting |SelectionModifier| to Layout NG.

Note: This patch is similar to the patch[1].

[1] http://crrev.com/2904813006: Change SelectionModifier::ModifyMovingLeft()
not to use redundant local variable

BUG=707656
TEST=n/a;

Review-Url: https://codereview.chromium.org/2906263002
Cr-Commit-Position: refs/heads/master@{#475430}
Committed: https://chromium.googlesource.com/chromium/src/+/362c1c955a0893adbbbbd53395c1f174df9f54c7

[yosin_UTC9, 2017-05-29 05:27:20]

Description was changed from

==========
2017-05-29T14:25:06

BUG=707656

2017-05-29T14:25:01
==========

to

==========
Change SelectionModifier::ModifyMovingRight() not to use redundant local
variable

This patch replaces redundant local variable |pop| with |return| statement in
|SelectionModifier::ModifyMovingRight()| to simplify and switches then-clause
and else-clause to reduce indentation for improving code health.

This patch also adds |NOTREACHED()| to catch unexpected cases.

This patch is a preparation of adopting |SelectionModifier| to Layout NG.

Note: This patch is similar to the patch[1].

[1] http://crrev.com/2904813006: Change SelectionModifier::ModifyMovingLeft()
not to use redundant local variable

BUG=707656
TEST=n/a;
==========

[yosin_UTC9, 2017-05-29 05:27:25]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-29 05:27:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-05-29 06:42:48]

yosin@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-05-29 06:42:49]

PTAL

[commit-bot: I haz the power, 2017-05-29 07:10:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 07:10:52]

Dry run: This issue passed the CQ dry run.

[yoichio, 2017-05-30 04:47:47]

lgtm

[yosin_UTC9, 2017-05-30 05:04:28]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-05-30 05:04:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 05:09:27]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496120668375400, "parent_rev":
"e5c34b46e460fcc5dd288659a3e11c6f290a8c6c", "commit_rev":
"362c1c955a0893adbbbbd53395c1f174df9f54c7"}

[commit-bot: I haz the power, 2017-05-30 05:09:36]

Description was changed from

==========
Change SelectionModifier::ModifyMovingRight() not to use redundant local
variable

This patch replaces redundant local variable |pop| with |return| statement in
|SelectionModifier::ModifyMovingRight()| to simplify and switches then-clause
and else-clause to reduce indentation for improving code health.

This patch also adds |NOTREACHED()| to catch unexpected cases.

This patch is a preparation of adopting |SelectionModifier| to Layout NG.

Note: This patch is similar to the patch[1].

[1] http://crrev.com/2904813006: Change SelectionModifier::ModifyMovingLeft()
not to use redundant local variable

BUG=707656
TEST=n/a;
==========

to

==========
Change SelectionModifier::ModifyMovingRight() not to use redundant local
variable

This patch replaces redundant local variable |pop| with |return| statement in
|SelectionModifier::ModifyMovingRight()| to simplify and switches then-clause
and else-clause to reduce indentation for improving code health.

This patch also adds |NOTREACHED()| to catch unexpected cases.

This patch is a preparation of adopting |SelectionModifier| to Layout NG.

Note: This patch is similar to the patch[1].

[1] http://crrev.com/2904813006: Change SelectionModifier::ModifyMovingLeft()
not to use redundant local variable

BUG=707656
TEST=n/a;

Review-Url: https://codereview.chromium.org/2906263002
Cr-Commit-Position: refs/heads/master@{#475430}
Committed:
https://chromium.googlesource.com/chromium/src/+/362c1c955a0893adbbbbd53395c1...
==========

[commit-bot: I haz the power, 2017-05-30 05:09:38]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/362c1c955a0893adbbbbd53395c1...