Revert of Allow storing multiple replacements on SpellCheckResult

Revert of Allow storing multiple replacements on SpellCheckResult (patchset #11 id:200001 of https://codereview.chromium.org/2848943002/ )

Reason for revert:
Caused spell markers to no longer appear on OSX, per crbug.com/727172

Original issue's description:
> Allow storing multiple replacements on SpellCheckResult
> 
> I'm working on adding support for the Android spellcheck suggestion list that
> appears in a native text box when you tap on a misspelled word. It appears that
> I need to modify this piece of infrastructure to support passing multiple
> suggestions through to the Spelling marker that gets added.
> 
> For reference, we construct the SpellCheckResult objects from the Android
> spellchecker results in SpellCheckerSessionBridge::ProcessSpellCheckResults().
> 
> Alternatively, ContextMenuClientImpl has logic for calling the spellchecker
> again to get the list of suggestions that we might be able to use:
> https://chromium.googlesource.com/chromium/src/+/adc8910776c64a876f0422454da618a37d01167b/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp#346
> 
> However, I talked to aelias and he said it would be better to store the
> suggestions the first time we call the spellchecker, at the time we add the
> marker, to avoid going back and forth unnecessarily.
> 
> BUG=715365
> 
> Review-Url: https://codereview.chromium.org/2848943002
> Cr-Commit-Position: refs/heads/master@{#475058}
> Committed: https://chromium.googlesource.com/chromium/src/+/c45f50742410a644a054325478d885e61d286713

TBR=jochen@chromium.org,aelias@chromium.org,groby@chromium.org,mkwst@chromium.org,xiaochengh@chromium.org,rlanday@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=715365, 727172
Review-Url: https://codereview.chromium.org/2906243002
Cr-Commit-Position: refs/heads/master@{#475293}
Committed: https://chromium.googlesource.com/chromium/src/+/e6a7d7e3cd5665b6bc9b0e8cac4c813c52f90b02

[Noel Gordon, 2017-05-29 03:27:08]

The CQ bit was checked by noel@chromium.org

[Noel Gordon, 2017-05-29 03:27:08]

Created Revert of Allow storing multiple replacements on SpellCheckResult

[commit-bot: I haz the power, 2017-05-29 03:27:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 03:29:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 03:29:40]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Noel Gordon, 2017-05-29 03:30:02]

Description was changed from

==========
Revert of Allow storing multiple replacements on SpellCheckResult (patchset #11
id:200001 of https://codereview.chromium.org/2848943002/ )

Reason for revert:
Caused spell markers to no longer appear on OSX, per crbug.com/727172

Original issue's description:
> Allow storing multiple replacements on SpellCheckResult
> 
> I'm working on adding support for the Android spellcheck suggestion list that
> appears in a native text box when you tap on a misspelled word. It appears
that
> I need to modify this piece of infrastructure to support passing multiple
> suggestions through to the Spelling marker that gets added.
> 
> For reference, we construct the SpellCheckResult objects from the Android
> spellchecker results in SpellCheckerSessionBridge::ProcessSpellCheckResults().
> 
> Alternatively, ContextMenuClientImpl has logic for calling the spellchecker
> again to get the list of suggestions that we might be able to use:
>
https://chromium.googlesource.com/chromium/src/+/adc8910776c64a876f0422454da6...
> 
> However, I talked to aelias and he said it would be better to store the
> suggestions the first time we call the spellchecker, at the time we add the
> marker, to avoid going back and forth unnecessarily.
> 
> BUG=715365
> 
> Review-Url: https://codereview.chromium.org/2848943002
> Cr-Commit-Position: refs/heads/master@{#475058}
> Committed:
https://chromium.googlesource.com/chromium/src/+/c45f50742410a644a054325478d8...

TBR=jochen@chromium.org,aelias@chromium.org,groby@chromium.org,mkwst@chromium...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=715365
==========

to

==========
Revert of Allow storing multiple replacements on SpellCheckResult (patchset #11
id:200001 of https://codereview.chromium.org/2848943002/ )

Reason for revert:
Caused spell markers to no longer appear on OSX, per crbug.com/727172

Original issue's description:
> Allow storing multiple replacements on SpellCheckResult
> 
> I'm working on adding support for the Android spellcheck suggestion list that
> appears in a native text box when you tap on a misspelled word. It appears
that
> I need to modify this piece of infrastructure to support passing multiple
> suggestions through to the Spelling marker that gets added.
> 
> For reference, we construct the SpellCheckResult objects from the Android
> spellchecker results in SpellCheckerSessionBridge::ProcessSpellCheckResults().
> 
> Alternatively, ContextMenuClientImpl has logic for calling the spellchecker
> again to get the list of suggestions that we might be able to use:
>
https://chromium.googlesource.com/chromium/src/+/adc8910776c64a876f0422454da6...
> 
> However, I talked to aelias and he said it would be better to store the
> suggestions the first time we call the spellchecker, at the time we add the
> marker, to avoid going back and forth unnecessarily.
> 
> BUG=715365
> 
> Review-Url: https://codereview.chromium.org/2848943002
> Cr-Commit-Position: refs/heads/master@{#475058}
> Committed:
https://chromium.googlesource.com/chromium/src/+/c45f50742410a644a054325478d8...

TBR=jochen@chromium.org,aelias@chromium.org,groby@chromium.org,mkwst@chromium...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=715365, 727172
==========

[Noel Gordon, 2017-05-29 03:55:48]

The CQ bit was checked by noel@chromium.org

[commit-bot: I haz the power, 2017-05-29 03:56:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Noel Gordon, 2017-05-29 03:56:09]

The CQ bit was unchecked by noel@chromium.org

[Noel Gordon, 2017-05-29 03:56:19]

The CQ bit was checked by noel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-29 03:56:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 05:48:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 05:48:55]

Dry run: This issue passed the CQ dry run.

[Noel Gordon, 2017-05-29 05:49:25]

The CQ bit was checked by noel@chromium.org

[commit-bot: I haz the power, 2017-05-29 05:49:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 05:54:18]

CQ is committing da patch.

Bot data: {"patchset_id": 270001, "attempt_start_ts": 1496036965960470,
"parent_rev": "64b85971b8b58c052b7e8b53754d5558b8e1dc53", "commit_rev":
"e6a7d7e3cd5665b6bc9b0e8cac4c813c52f90b02"}

[commit-bot: I haz the power, 2017-05-29 05:54:32]

Description was changed from

==========
Revert of Allow storing multiple replacements on SpellCheckResult (patchset #11
id:200001 of https://codereview.chromium.org/2848943002/ )

Reason for revert:
Caused spell markers to no longer appear on OSX, per crbug.com/727172

Original issue's description:
> Allow storing multiple replacements on SpellCheckResult
> 
> I'm working on adding support for the Android spellcheck suggestion list that
> appears in a native text box when you tap on a misspelled word. It appears
that
> I need to modify this piece of infrastructure to support passing multiple
> suggestions through to the Spelling marker that gets added.
> 
> For reference, we construct the SpellCheckResult objects from the Android
> spellchecker results in SpellCheckerSessionBridge::ProcessSpellCheckResults().
> 
> Alternatively, ContextMenuClientImpl has logic for calling the spellchecker
> again to get the list of suggestions that we might be able to use:
>
https://chromium.googlesource.com/chromium/src/+/adc8910776c64a876f0422454da6...
> 
> However, I talked to aelias and he said it would be better to store the
> suggestions the first time we call the spellchecker, at the time we add the
> marker, to avoid going back and forth unnecessarily.
> 
> BUG=715365
> 
> Review-Url: https://codereview.chromium.org/2848943002
> Cr-Commit-Position: refs/heads/master@{#475058}
> Committed:
https://chromium.googlesource.com/chromium/src/+/c45f50742410a644a054325478d8...

TBR=jochen@chromium.org,aelias@chromium.org,groby@chromium.org,mkwst@chromium...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=715365, 727172
==========

to

==========
Revert of Allow storing multiple replacements on SpellCheckResult (patchset #11
id:200001 of https://codereview.chromium.org/2848943002/ )

Reason for revert:
Caused spell markers to no longer appear on OSX, per crbug.com/727172

Original issue's description:
> Allow storing multiple replacements on SpellCheckResult
> 
> I'm working on adding support for the Android spellcheck suggestion list that
> appears in a native text box when you tap on a misspelled word. It appears
that
> I need to modify this piece of infrastructure to support passing multiple
> suggestions through to the Spelling marker that gets added.
> 
> For reference, we construct the SpellCheckResult objects from the Android
> spellchecker results in SpellCheckerSessionBridge::ProcessSpellCheckResults().
> 
> Alternatively, ContextMenuClientImpl has logic for calling the spellchecker
> again to get the list of suggestions that we might be able to use:
>
https://chromium.googlesource.com/chromium/src/+/adc8910776c64a876f0422454da6...
> 
> However, I talked to aelias and he said it would be better to store the
> suggestions the first time we call the spellchecker, at the time we add the
> marker, to avoid going back and forth unnecessarily.
> 
> BUG=715365
> 
> Review-Url: https://codereview.chromium.org/2848943002
> Cr-Commit-Position: refs/heads/master@{#475058}
> Committed:
https://chromium.googlesource.com/chromium/src/+/c45f50742410a644a054325478d8...

TBR=jochen@chromium.org,aelias@chromium.org,groby@chromium.org,mkwst@chromium...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=715365, 727172

Review-Url: https://codereview.chromium.org/2906243002
Cr-Commit-Position: refs/heads/master@{#475293}
Committed:
https://chromium.googlesource.com/chromium/src/+/e6a7d7e3cd5665b6bc9b0e8cac4c...
==========

[commit-bot: I haz the power, 2017-05-29 05:54:35]

Committed patchset #2 (id:270001) as
https://chromium.googlesource.com/chromium/src/+/e6a7d7e3cd5665b6bc9b0e8cac4c...