[LayoutNG] Use logical left of the line box to apply text-align

[LayoutNG] Use logical left of the line box to apply text-align

This patch changes text-align to use the logical left of the line box to
apply the CSS text-align property. This is set to the offset of
NGPhysicalLineBoxFragment, which is then copiped to
RootInlineBox::LogicalLeft.

This way is more efficient to move, the same as what the legacy does,
and better for painting since the line box does not have unused spaces.

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng

Review-Url: https://codereview.chromium.org/2906233002
Cr-Commit-Position: refs/heads/master@{#475728}
Committed: https://chromium.googlesource.com/chromium/src/+/a1680fcaff1aa1c755f52a2b8942cf871b773a32

[kojii, 2017-05-28 18:57:51]

Description was changed from

==========
ngtextalign

BUG=
==========

to

==========
ngtextalign

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[kojii, 2017-05-28 18:57:59]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-28 18:58:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-28 20:20:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-28 20:20:27]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kojii, 2017-05-29 01:56:08]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-29 01:56:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 05:32:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 05:32:15]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_layout_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[kojii, 2017-05-29 11:07:39]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-29 11:07:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 15:24:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 15:24:58]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_layout_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))

[kojii, 2017-05-29 16:15:41]

Description was changed from

==========
ngtextalign

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
[LayoutNG] Use logical left of the line box to apply text-align

This patch changes text-align to use the logical left of the line box to
apply the CSS text-align property. This is set to the offset of
NGPhysicalLineBoxFragment, which is then copiped to
RootInlineBox::LogicalLeft.

This way is more efficient to move, the same as what the legacy does,
and better for painting since the line box does not have unused spaces.

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[kojii, 2017-05-29 16:16:47]

kojii@chromium.org changed reviewers:
+ eae@chromium.org, glebl@chromium.org, lchoi@chromium.org

[kojii, 2017-05-29 16:16:48]

PTAL.

lchoi@, I saw you're working on supporting center alignment. Could you rebase on
top of this?

[eae, 2017-05-30 15:01:45]

LGTM

[kojii, 2017-05-30 17:59:02]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2017-05-30 17:59:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 20:01:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 20:01:42]

Try jobs failed on following builders:
  linux_layout_tests_layout_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))

[kojii, 2017-05-31 01:36:47]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2017-05-31 01:37:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 01:42:12]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1496194607374700,
"parent_rev": "ba56247f89fbab82338c09aeb22afb2762a4eef2", "commit_rev":
"a1680fcaff1aa1c755f52a2b8942cf871b773a32"}

[commit-bot: I haz the power, 2017-05-31 01:42:21]

Description was changed from

==========
[LayoutNG] Use logical left of the line box to apply text-align

This patch changes text-align to use the logical left of the line box to
apply the CSS text-align property. This is set to the offset of
NGPhysicalLineBoxFragment, which is then copiped to
RootInlineBox::LogicalLeft.

This way is more efficient to move, the same as what the legacy does,
and better for painting since the line box does not have unused spaces.

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
[LayoutNG] Use logical left of the line box to apply text-align

This patch changes text-align to use the logical left of the line box to
apply the CSS text-align property. This is set to the offset of
NGPhysicalLineBoxFragment, which is then copiped to
RootInlineBox::LogicalLeft.

This way is more efficient to move, the same as what the legacy does,
and better for painting since the line box does not have unused spaces.

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng

Review-Url: https://codereview.chromium.org/2906233002
Cr-Commit-Position: refs/heads/master@{#475728}
Committed:
https://chromium.googlesource.com/chromium/src/+/a1680fcaff1aa1c755f52a2b8942...
==========

[commit-bot: I haz the power, 2017-05-31 01:42:22]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/a1680fcaff1aa1c755f52a2b8942...