Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2906193002: Disable DCHECK for external reference address uniqueness on Windows (Closed)

Created:
3 years, 6 months ago by hans
Modified:
3 years, 6 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, Yang, Nico
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Disable DCHECK for external reference address uniqueness on Windows The memcpy and memmove externals can end up at the same address; see bug for details. BUG=chromium:726896 Review-Url: https://codereview.chromium.org/2906193002 Cr-Commit-Position: refs/heads/master@{#45545} Committed: https://chromium.googlesource.com/v8/v8/+/c05ca9d7b8ef74d73959a3d582c26dbdbf5f0c7e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/snapshot/serializer-common.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
hans
Please take a look.
3 years, 6 months ago (2017-05-27 01:20:58 UTC) #2
Yang
lgtm. thanks!
3 years, 6 months ago (2017-05-27 02:05:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2906193002/1
3 years, 6 months ago (2017-05-27 02:05:45 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-05-27 02:34:37 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/c05ca9d7b8ef74d73959a3d582c26dbdbf5...

Powered by Google App Engine
This is Rietveld 408576698