Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 2906133002: [ios clean] Fixes ToolsMediator unit test (Closed)

Created:
3 years, 6 months ago by sczs
Modified:
3 years, 6 months ago
Reviewers:
edchin
CC:
chromium-reviews, marq+scrutinize_chromium.org, ios-reviews+clean_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios clean] Fixes ToolsMediator unit test Changes EXPECT_EQ to EXPECT_NSEQ for NSString comparisons. BUG=682880 Review-Url: https://codereview.chromium.org/2906133002 Cr-Commit-Position: refs/heads/master@{#475067} Committed: https://chromium.googlesource.com/chromium/src/+/9b7f68fcf6b065e000dcb23e2a54ad7869c7c9f9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M ios/clean/chrome/browser/ui/tools/tools_mediator_unittest.mm View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
sczs
Ed, PTAL!
3 years, 6 months ago (2017-05-26 18:13:21 UTC) #4
edchin
lgtm
3 years, 6 months ago (2017-05-26 18:14:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2906133002/1
3 years, 6 months ago (2017-05-26 18:14:54 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-05-26 18:30:06 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9b7f68fcf6b065e000dcb23e2a54...

Powered by Google App Engine
This is Rietveld 408576698