Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3288)

Unified Diff: chrome/browser/safe_browsing/chrome_cleaner/settings_resetter_browsertest_win.cc

Issue 2906103002: Post-cleanup settings reset. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/chrome_cleaner/settings_resetter_browsertest_win.cc
diff --git a/chrome/browser/safe_browsing/chrome_cleaner/settings_resetter_browsertest_win.cc b/chrome/browser/safe_browsing/chrome_cleaner/settings_resetter_browsertest_win.cc
new file mode 100644
index 0000000000000000000000000000000000000000..589a6720e7e304452ae5de577566129ffa705d70
--- /dev/null
+++ b/chrome/browser/safe_browsing/chrome_cleaner/settings_resetter_browsertest_win.cc
@@ -0,0 +1,150 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/safe_browsing/chrome_cleaner/settings_resetter_win.h"
+
+#include <memory>
+
+#include "base/files/file_path.h"
+#include "base/files/file_util.h"
+#include "base/files/scoped_temp_dir.h"
+#include "base/run_loop.h"
+#include "base/test/test_reg_util_win.h"
+#include "base/threading/thread_restrictions.h"
+#include "base/win/registry.h"
+#include "chrome/browser/browser_process.h"
+#include "chrome/browser/profile_resetter/brandcoded_default_settings.h"
+#include "chrome/browser/profile_resetter/profile_resetter.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_prefs_manager_win.h"
+#include "chrome/browser/safe_browsing/settings_reset_prompt/default_settings_fetcher.h"
+#include "chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_test_utils.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/browser_finder.h"
+#include "chrome/common/pref_names.h"
+#include "chrome/test/base/in_process_browser_test.h"
+#include "chrome/test/base/search_test_utils.h"
+#include "components/chrome_cleaner/public/constants/constants.h"
+#include "components/prefs/pref_service.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace safe_browsing {
+namespace {
+
+using ::testing::_;
+using ::testing::StrictMock;
+
+// Saves |value| in the registry at the Chrome Cleaner registry key
+void SetValueIfPositive(const wchar_t* value_name, int64_t value) {
+ if (value <= 0)
+ return;
+
+ base::string16 cleaner_key_path(
+ chrome_cleaner::kSoftwareRemovalToolRegistryKey);
+ cleaner_key_path.append(L"\\").append(chrome_cleaner::kCleanerSubKey);
+
+ LONG result = base::win::RegKey(HKEY_CURRENT_USER, cleaner_key_path.c_str(),
+ KEY_SET_VALUE)
+ .WriteValue(value_name, &value, sizeof(value), REG_QWORD);
+ ASSERT_EQ(ERROR_SUCCESS, result);
+}
+
+Profile* GetProfile() {
+ Browser* browser = chrome::FindLastActive();
+ return browser ? browser->profile() : nullptr;
+}
+
+class TagCurrentProfileForResettingTest : public InProcessBrowserTest {};
+
+IN_PROC_BROWSER_TEST_F(TagCurrentProfileForResettingTest, Run) {
+ TagCurrentProfileForResetting();
+
+ EXPECT_TRUE(ChromeCleanerPrefsManager(GetProfile()).SettingsResetPending());
+}
+
+class SettingsResetterTestDelegate : public SettingsResetterDelegate {
+ public:
+ SettingsResetterTestDelegate(
+ std::unique_ptr<ProfileResetter> profile_resetter)
+ : profile_resetter_(std::move(profile_resetter)) {}
+ ~SettingsResetterTestDelegate() override = default;
+
+ void FetchDefaultSettings(
+ DefaultSettingsFetcher::SettingsCallback callback) override {
+ callback.Run(base::MakeUnique<BrandcodedDefaultSettings>());
+ }
+
+ std::unique_ptr<ProfileResetter> GetProfileResetter(
+ Profile* profile) override {
+ return std::move(profile_resetter_);
+ }
+
+ private:
+ std::unique_ptr<ProfileResetter> profile_resetter_;
+};
+
+const struct SettingsResetTestParams {
+ int64_t ts_cleanup_started;
+ int64_t ts_cleanup_completed;
+ bool settings_reset;
+} kSettingsResetTestParams[] = {{0, 0, false},
+ {10000, 0, false},
+ {0, 20000, false},
+ {20000, 10000, false},
+ {10000, 20000, true}};
+
+class ResetCurrentProfilePostCleanupIfTaggedTest
+ : public InProcessBrowserTest,
+ public ::testing::WithParamInterface<SettingsResetTestParams> {
+ public:
+ void SetUpOnMainThread() override {
+ InProcessBrowserTest::SetUpOnMainThread();
+ params_ = GetParam();
+ }
+
+ protected:
+ SettingsResetTestParams params_;
+
+ registry_util::RegistryOverrideManager registry_override_manager_;
+};
+
+IN_PROC_BROWSER_TEST_P(ResetCurrentProfilePostCleanupIfTaggedTest, Run) {
+ ASSERT_NO_FATAL_FAILURE(
+ registry_override_manager_.OverrideRegistry(HKEY_CURRENT_USER));
+ SetValueIfPositive(chrome_cleaner::kCleanupStartedTimestampValueName,
+ params_.ts_cleanup_started);
+ SetValueIfPositive(chrome_cleaner::kCleanupConfirmedTimestampValueName,
+ params_.ts_cleanup_completed);
+
+ Profile* profile = GetProfile();
+ ASSERT_TRUE(profile);
+ ChromeCleanerPrefsManager(profile).RecordSettingsResetPending(true);
+
+ std::unique_ptr<ProfileResetter> profile_resetter;
+ if (params_.settings_reset) {
+ auto mock_profile_resetter =
+ base::MakeUnique<StrictMock<MockProfileResetter>>(profile);
+ EXPECT_CALL(*mock_profile_resetter, MockReset(_, _, _));
+
+ profile_resetter.reset(mock_profile_resetter.release());
+ }
+
+ auto delegate = base::MakeUnique<SettingsResetterTestDelegate>(
+ std::move(profile_resetter));
+
+ base::RunLoop run_loop;
+ ResetCurrentProfilePostCleanupIfTagged(run_loop.QuitClosure(),
+ std::move(delegate));
+ run_loop.Run();
+}
+
+INSTANTIATE_TEST_CASE_P(Default,
+ ResetCurrentProfilePostCleanupIfTaggedTest,
+ testing::ValuesIn(kSettingsResetTestParams));
+
+} // namespace
+} // namespace safe_browsing

Powered by Google App Engine
This is Rietveld 408576698