Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Side by Side Diff: chrome/browser/safe_browsing/chrome_cleaner/settings_resetter_browsertest_win.cc

Issue 2906103002: Post-cleanup settings reset. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/safe_browsing/chrome_cleaner/settings_resetter_win.h"
6
7 #include <memory>
8
9 #include "base/files/file_path.h"
10 #include "base/files/file_util.h"
11 #include "base/files/scoped_temp_dir.h"
12 #include "base/run_loop.h"
13 #include "base/test/test_reg_util_win.h"
14 #include "base/threading/thread_restrictions.h"
15 #include "base/win/registry.h"
16 #include "chrome/browser/browser_process.h"
17 #include "chrome/browser/profile_resetter/brandcoded_default_settings.h"
18 #include "chrome/browser/profile_resetter/profile_resetter.h"
19 #include "chrome/browser/profiles/profile.h"
20 #include "chrome/browser/profiles/profile_manager.h"
21 #include "chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_prefs_manag er_win.h"
22 #include "chrome/browser/safe_browsing/settings_reset_prompt/default_settings_fe tcher.h"
23 #include "chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prom pt_test_utils.h"
24 #include "chrome/browser/ui/browser.h"
25 #include "chrome/browser/ui/browser_finder.h"
26 #include "chrome/common/pref_names.h"
27 #include "chrome/test/base/in_process_browser_test.h"
28 #include "chrome/test/base/search_test_utils.h"
29 #include "components/chrome_cleaner/public/constants/constants.h"
30 #include "components/prefs/pref_service.h"
31 #include "content/public/test/test_browser_thread_bundle.h"
32 #include "testing/gmock/include/gmock/gmock.h"
33 #include "testing/gtest/include/gtest/gtest.h"
34
35 namespace safe_browsing {
36 namespace {
37
38 using ::testing::_;
39 using ::testing::StrictMock;
40
41 // Saves |value| in the registry at the Chrome Cleaner registry key
42 void SetValueIfPositive(const wchar_t* value_name, int64_t value) {
43 if (value <= 0)
44 return;
45
46 base::string16 cleaner_key_path(
47 chrome_cleaner::kSoftwareRemovalToolRegistryKey);
48 cleaner_key_path.append(L"\\").append(chrome_cleaner::kCleanerSubKey);
49
50 LONG result = base::win::RegKey(HKEY_CURRENT_USER, cleaner_key_path.c_str(),
51 KEY_SET_VALUE)
52 .WriteValue(value_name, &value, sizeof(value), REG_QWORD);
53 ASSERT_EQ(ERROR_SUCCESS, result);
54 }
55
56 Profile* GetProfile() {
57 Browser* browser = chrome::FindLastActive();
58 return browser ? browser->profile() : nullptr;
59 }
60
61 class TagCurrentProfileForResettingTest : public InProcessBrowserTest {};
62
63 IN_PROC_BROWSER_TEST_F(TagCurrentProfileForResettingTest, Run) {
64 TagCurrentProfileForResetting();
65
66 EXPECT_TRUE(ChromeCleanerPrefsManager(GetProfile()).SettingsResetPending());
67 }
68
69 class SettingsResetterTestDelegate : public SettingsResetterDelegate {
70 public:
71 SettingsResetterTestDelegate(
72 std::unique_ptr<ProfileResetter> profile_resetter)
73 : profile_resetter_(std::move(profile_resetter)) {}
74 ~SettingsResetterTestDelegate() override = default;
75
76 void FetchDefaultSettings(
77 DefaultSettingsFetcher::SettingsCallback callback) override {
78 callback.Run(base::MakeUnique<BrandcodedDefaultSettings>());
79 }
80
81 std::unique_ptr<ProfileResetter> GetProfileResetter(
82 Profile* profile) override {
83 return std::move(profile_resetter_);
84 }
85
86 private:
87 std::unique_ptr<ProfileResetter> profile_resetter_;
88 };
89
90 const struct SettingsResetTestParams {
91 int64_t ts_cleanup_started;
92 int64_t ts_cleanup_completed;
93 bool settings_reset;
94 } kSettingsResetTestParams[] = {{0, 0, false},
95 {10000, 0, false},
96 {0, 20000, false},
97 {20000, 10000, false},
98 {10000, 20000, true}};
99
100 class ResetCurrentProfilePostCleanupIfTaggedTest
101 : public InProcessBrowserTest,
102 public ::testing::WithParamInterface<SettingsResetTestParams> {
103 public:
104 void SetUpOnMainThread() override {
105 InProcessBrowserTest::SetUpOnMainThread();
106 params_ = GetParam();
107 }
108
109 protected:
110 SettingsResetTestParams params_;
111
112 registry_util::RegistryOverrideManager registry_override_manager_;
113 };
114
115 IN_PROC_BROWSER_TEST_P(ResetCurrentProfilePostCleanupIfTaggedTest, Run) {
116 ASSERT_NO_FATAL_FAILURE(
117 registry_override_manager_.OverrideRegistry(HKEY_CURRENT_USER));
118 SetValueIfPositive(chrome_cleaner::kCleanupStartedTimestampValueName,
119 params_.ts_cleanup_started);
120 SetValueIfPositive(chrome_cleaner::kCleanupConfirmedTimestampValueName,
121 params_.ts_cleanup_completed);
122
123 Profile* profile = GetProfile();
124 ASSERT_TRUE(profile);
125 ChromeCleanerPrefsManager(profile).RecordSettingsResetPending(true);
126
127 std::unique_ptr<ProfileResetter> profile_resetter;
128 if (params_.settings_reset) {
129 auto mock_profile_resetter =
130 base::MakeUnique<StrictMock<MockProfileResetter>>(profile);
131 EXPECT_CALL(*mock_profile_resetter, MockReset(_, _, _));
132
133 profile_resetter.reset(mock_profile_resetter.release());
134 }
135
136 auto delegate = base::MakeUnique<SettingsResetterTestDelegate>(
137 std::move(profile_resetter));
138
139 base::RunLoop run_loop;
140 ResetCurrentProfilePostCleanupIfTagged(run_loop.QuitClosure(),
141 std::move(delegate));
142 run_loop.Run();
143 }
144
145 INSTANTIATE_TEST_CASE_P(Default,
146 ResetCurrentProfilePostCleanupIfTaggedTest,
147 testing::ValuesIn(kSettingsResetTestParams));
148
149 } // namespace
150 } // namespace safe_browsing
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698