Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 2906063004: [Android] Reimplementing BTSJobSerivce delegate to not overwrite tasks (Closed)

Created:
3 years, 6 months ago by fgorski
Modified:
3 years, 6 months ago
Reviewers:
nyquist
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Reimplementing BTSJobSerivce delegate to not overwrite tasks Change includes looking through all scheduled jobs and not scheduling a task if there is already a pending job with matching ID We cannot use getPendingJob as it is not available until API v24. BUG=726860 Review-Url: https://codereview.chromium.org/2906063004 Cr-Commit-Position: refs/heads/master@{#475183} Committed: https://chromium.googlesource.com/chromium/src/+/c33f7598aadfe913c6b4718e3b879ded0444140a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M components/background_task_scheduler/android/java/src/org/chromium/components/background_task_scheduler/BackgroundTaskSchedulerJobService.java View 3 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
fgorski
PTAL
3 years, 6 months ago (2017-05-26 22:00:40 UTC) #3
nyquist
lgtm do we want to write something in the documentation about this in the future, ...
3 years, 6 months ago (2017-05-26 22:06:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2906063004/1
3 years, 6 months ago (2017-05-26 23:20:36 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-05-26 23:25:42 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c33f7598aadfe913c6b4718e3b87...

Powered by Google App Engine
This is Rietveld 408576698