Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2906063002: Move StatsTable into the Counters class. (Closed)

Created:
3 years, 6 months ago by kschimpf
Modified:
3 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Move StatsTable into the Counters class. By moving StatsTable from class Isolate to class Counters, it make the class StatsTable thead safe. This is needed because these two classes call each other, and for background compilation, instances of the Counters class can persist longer that the corresponding Isolate it came from. It also removes unnecessary hops to the the Isolate, and checks if the StatsTable has been created, for these communications. BUG=v8:6361 Review-Url: https://codereview.chromium.org/2906063002 Cr-Commit-Position: refs/heads/master@{#45576} Committed: https://chromium.googlesource.com/v8/v8/+/2a9965bd0ecf90393d785425b97c5045fc0b5316

Patch Set 1 #

Patch Set 2 : Remove deleting stats_table_ in isolate. #

Patch Set 3 : Fix nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -55 lines) Patch
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/counters.h View 1 2 11 chunks +30 lines, -26 lines 0 comments Download
M src/counters.cc View 11 chunks +23 lines, -22 lines 0 comments Download
M src/isolate.cc View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (15 generated)
kschimpf
Please review. Thanks.
3 years, 6 months ago (2017-05-26 17:44:15 UTC) #11
jochen (gone - plz use gerrit)
lgtm
3 years, 6 months ago (2017-05-29 14:11:46 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2906063002/40001
3 years, 6 months ago (2017-05-29 17:04:09 UTC) #16
commit-bot: I haz the power
3 years, 6 months ago (2017-05-29 18:18:33 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/2a9965bd0ecf90393d785425b97c5045fc0...

Powered by Google App Engine
This is Rietveld 408576698